Use mesh-specialized eachelement to maintain compatibility with new DGMulti cache structure#160
Merged
tristanmontoya merged 15 commits intomainfrom Mar 19, 2026
Merged
Conversation
…m/fix_dgmulti_threading
…m/fix_dgmulti_threading
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
=======================================
Coverage 97.08% 97.08%
=======================================
Files 37 37
Lines 5010 5010
=======================================
Hits 4864 4864
Misses 146 146 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benegee
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick fix to get Trixi.jl's downstream TrixiAtmo.jl tests to pass after DGMulti container changes (this PR avoids accessing the DGMulti
solution_container, which we don't have yet in TrixiAtmo.jl). After the next Trixi.jl patch release, we will revisit the TrixiAtmo.jl containers for consistency. Will close #159.