Fh/clouds and rain #95
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kes and formatting
…fixed rainy source signs, added boundary flux calculations, added temporary debugging code
…nique struct names
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
===========================================
- Coverage 90.68% 67.09% -23.59%
===========================================
Files 22 29 +7
Lines 2189 3455 +1266
===========================================
+ Hits 1985 2318 +333
- Misses 204 1137 +933 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main addition of this branch are the
CompressibleRainyEulerEquations2D, modelling dry air, water vapour, cloud water and rain water density species. This implementation has an implicit solver for vapour saturation effects, like in https://doi.org/10.1016/j.jcp.2023.112713.An entropy conserving two-point numerical flux for use with rain is also included (
flux_ec_rain), as well asCompressibleRainyEulerExplicitEquations2Dand other systems of equations, mainly used for testing and comparison.Here a quick example of the
elixir_rainy_euler_rainy_bubble_diffusion.jlat mesh refinement 7, after 600s simulated time.