Add a macro version of trixi_include to use the right module automatically#51
Open
Add a macro version of trixi_include to use the right module automatically#51
Conversation
JoshuaLampert
requested changes
Aug 20, 2025
Member
JoshuaLampert
left a comment
There was a problem hiding this comment.
Nice idea. Can you also export the macro, please?
ranocha
requested changes
Aug 20, 2025
Member
ranocha
left a comment
There was a problem hiding this comment.
Thanks, I like the idea. Could you please
- export the macro to fix CI
- add a test for the error path in the macro
- add a test with multiple keyword arguments
? Programming macros is always a bit scary in Julia compared to normal functions, so I would like to have a bit better test coverage for it to make it easier for people working with the code in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just ran into the footgun that in tests or in Documenter
trixi_includeuses the wrong module.Using a macro we can query the calling module with
__module__and allow for "prettier" usage.I personally prefer macros for "magic" functionality like trixi_include