Skip to content

Fix issues found by JET.jl#57

Merged
ranocha merged 6 commits intomainfrom
fix-JET
Nov 4, 2025
Merged

Fix issues found by JET.jl#57
ranocha merged 6 commits intomainfrom
fix-JET

Conversation

@JoshuaLampert
Copy link
Copy Markdown
Member

In DispersiveShallowWater.jl, we get errors from JET.jl v0.11, which stem from @trixi-timeit in TrixiBase.jl, see NumericalMathematics/DispersiveShallowWater.jl#248 (comment): local variable accumulated_data may be undefined: accumulated_data::TimerOutputs.TimeData. This PR puts accumulated_data in the second if block to fix this. I verified locally that this fixes the issue.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.56%. Comparing base (45d85d5) to head (b85f488).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   94.56%   94.56%           
=======================================
  Files           5        5           
  Lines         313      313           
=======================================
  Hits          296      296           
  Misses         17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoshuaLampert
Copy link
Copy Markdown
Member Author

JoshuaLampert commented Nov 3, 2025

Failing tests are due to world age issues with trixi_include introduced in Julia v1.12 and already appeared in https://github.com/trixi-framework/TrixiBase.jl/actions/runs/18938535502/job/54071313304 (which was the first test run, where Julia v1 was resolved to v1.12). Edit: Should be fixed with #58.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 3, 2025

Pull Request Test Coverage Report for Build 19049452490

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 94.569%

Files with Coverage Reduction New Missed Lines %
src/trixi_timeit.jl 1 83.33%
src/TrixiBase.jl 3 0.0%
Totals Coverage Status
Change from base Build 19046170447: 0.0%
Covered Lines: 296
Relevant Lines: 313

💛 - Coveralls

3 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 3, 2025

Pull Request Test Coverage Report for Build 19049452490

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 94.569%

Files with Coverage Reduction New Missed Lines %
src/trixi_timeit.jl 1 83.33%
src/TrixiBase.jl 3 0.0%
Totals Coverage Status
Change from base Build 19046170447: 0.0%
Covered Lines: 296
Relevant Lines: 313

💛 - Coveralls

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 3, 2025

Pull Request Test Coverage Report for Build 19049452490

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 94.569%

Files with Coverage Reduction New Missed Lines %
src/trixi_timeit.jl 1 83.33%
src/TrixiBase.jl 3 0.0%
Totals Coverage Status
Change from base Build 19046170447: 0.0%
Covered Lines: 296
Relevant Lines: 313

💛 - Coveralls

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 3, 2025

Pull Request Test Coverage Report for Build 19049452490

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 94.569%

Files with Coverage Reduction New Missed Lines %
src/trixi_timeit.jl 1 83.33%
src/TrixiBase.jl 3 0.0%
Totals Coverage Status
Change from base Build 19046170447: 0.0%
Covered Lines: 296
Relevant Lines: 313

💛 - Coveralls

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 3, 2025

Pull Request Test Coverage Report for Build 19068357829

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.569%

Totals Coverage Status
Change from base Build 19046170447: 0.0%
Covered Lines: 296
Relevant Lines: 313

💛 - Coveralls

@JoshuaLampert JoshuaLampert requested a review from ranocha November 4, 2025 12:20
Copy link
Copy Markdown
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ranocha ranocha merged commit 7d4377c into main Nov 4, 2025
12 checks passed
@ranocha ranocha deleted the fix-JET branch November 4, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants