Skip to content

Conversation

@github-actions
Copy link
Contributor

This pull request sets the compat entry for the TrixiBottomTopography package to 0.1 for package docs.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
Note: Consider registering a new release of your package immediately after merging this PR, as downstream packages may depend on this for tests to pass.

…on 0.1 for package docs, (keep existing compat)
@andrewwinters5000 andrewwinters5000 force-pushed the compathelper/new_version/2025-09-26-13-02-50-621-03187559760 branch from 75aa85d to 92f65bd Compare September 26, 2025 13:02
@andrewwinters5000
Copy link
Member

@sloede @JoshuaLampert Do we need a compat bound like this in the docs/Project.toml neither Trixi.jl nor TrixiShallowWater.jl have such a compat.

@JoshuaLampert
Copy link
Member

Yes, we don't need it. I'm honestly not sure why CompatHelper.jl suggests this here, but not elsewhere.

@andrewwinters5000
Copy link
Member

Thanks, then I will close this PR and delete this branch.

@JoshuaLampert
Copy link
Member

Oh, now I know. We don't need TrixiBT.jl in [deps].

@JoshuaLampert
Copy link
Member

Thanks, then I will close this PR and delete this branch.

If we only close this PR, CompatHelper will create a new one. So I suggest to remove TrixiBT.jl from deps in docs/Project.toml.

@andrewwinters5000
Copy link
Member

andrewwinters5000 commented Sep 26, 2025

But that is weird. Both Trixi and TrixiShallowWater are in the deps for their respective docs/Project.toml?

@JoshuaLampert
Copy link
Member

In Trixi.jl we have trixi-framework/Trixi.jl#2489 and in TrixiSW.jl CompatHelper is disabled: https://github.com/trixi-framework/TrixiShallowWater.jl/actions/workflows/CompatHelper.yml.

@JoshuaLampert
Copy link
Member

In Trixi.jl we have a sources entry: https://github.com/trixi-framework/Trixi.jl/blob/e842dd265340a1524cc56b79ab270f745e9ea4b5/docs/Project.toml#L29. So it's fine to have Trixi.jl in [deps]. In TrixiSW.jl I would also recommend to remove it.

@andrewwinters5000
Copy link
Member

Aha, gotcha. We can remove it here (as well as in TrixiSW most likely).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants