Skip to content

Remove non-coverage tests#109

Merged
ranocha merged 2 commits intomainfrom
remove-noncoverage-tests
Jul 24, 2025
Merged

Remove non-coverage tests#109
ranocha merged 2 commits intomainfrom
remove-noncoverage-tests

Conversation

@JoshuaLampert
Copy link
Copy Markdown
Member

As explained in #108 the more complex splitting between coverage and non-coverage tests should be obsolete by now. This PR removes the non-coverage tests and is based on trixi-framework/Trixi.jl#2254 (and trixi-framework/Trixi.jl#2261).

@JoshuaLampert
Copy link
Copy Markdown
Member Author

With this PR, the upstream - * tests can be removed from the list of required status checks.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.34%. Comparing base (7692ca7) to head (aca0031).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   99.30%   99.34%   +0.05%     
==========================================
  Files          82       82              
  Lines        4263     4263              
==========================================
+ Hits         4233     4235       +2     
+ Misses         30       28       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoshuaLampert
Copy link
Copy Markdown
Member Author

Hm, I don't quite understand why coverage reports a lot of missing parts. It seems to recognize most tests, but not all.

@JoshuaLampert
Copy link
Copy Markdown
Member Author

So now after rerunning CI, coverage is happy again, i.e., this is ready for review from my point of view.

@JoshuaLampert JoshuaLampert requested a review from ranocha July 24, 2025 14:07
@JoshuaLampert
Copy link
Copy Markdown
Member Author

I think Patrick and Andrew are on vacation this week. Do you have the rights to remove the upstream - * tests from the required status checks, @ranocha? If so, maybe we could go on with merging, such that we can continue with the other PR(s) regarding moving to TrixiTest.jl?

@ranocha ranocha merged commit 0bb3f93 into main Jul 24, 2025
29 checks passed
@ranocha ranocha deleted the remove-noncoverage-tests branch July 24, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants