Conversation
|
With this PR, the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 99.30% 99.34% +0.05%
==========================================
Files 82 82
Lines 4263 4263
==========================================
+ Hits 4233 4235 +2
+ Misses 30 28 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hm, I don't quite understand why coverage reports a lot of missing parts. It seems to recognize most tests, but not all. |
|
So now after rerunning CI, coverage is happy again, i.e., this is ready for review from my point of view. |
|
I think Patrick and Andrew are on vacation this week. Do you have the rights to remove the |
As explained in #108 the more complex splitting between coverage and non-coverage tests should be obsolete by now. This PR removes the non-coverage tests and is based on trixi-framework/Trixi.jl#2254 (and trixi-framework/Trixi.jl#2261).