Add Shallow water moment equation models in 1D#128
Add Shallow water moment equation models in 1D#128andrewwinters5000 merged 22 commits intotrixi-framework:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
- Coverage 99.32% 99.27% -0.05%
==========================================
Files 87 94 +7
Lines 4587 5092 +505
==========================================
+ Hits 4556 5055 +499
- Misses 31 37 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrewwinters5000
left a comment
There was a problem hiding this comment.
Thanks for adding the new equation systems and functionality! I only left a few comments.
examples/tree_1d_dgsem/elixir_shallowwater_moments_convergence.jl
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
andrewwinters5000
left a comment
There was a problem hiding this comment.
Everything looks good to me. The small drop in coverage is acceptable as noise.
andrewwinters5000
left a comment
There was a problem hiding this comment.
It all looks good to me! Just one small thing for the sake of consistency; in the Monai tutorial we could maybe change source_terms_manning_friction to be source_term_manning_friction on lines 265 and 319 in the file docs/src/tutorials/elixir_shallowwater_monai_tsunami.jl.
@andrewwinters5000 Right, we should make that consistent. However, we currently have not implemented Should we just open an issue for now and then properly implement the |
Yeah, let's just open an issue about naming consistency of the friction source terms. This should be done separate from this feature PR. |
|
I have created issue #129 to document the inconsistency and will start working on a respective PR soon. With that I think everything should be addressed in this PR. |
I agree, we are good to merge. |
f0c6807
into
trixi-framework:main


This PR adds two new equation types for the one-dimensional Shallow water moment equations and Shallow water linearized moment equations:
ShallowWaterMomentEquations1DShallowWaterLinearizedMomentEquations1DDetails about the implementation and models can be found in the preprint:
Entropy analysis and entropy stable DG methods for the shallow water moment equations
DOI: 10.48550/arXiv.2602.06513