Skip to content

OrdinaryDiffEq updates#276

Merged
benegee merged 13 commits intomainfrom
bg/fix-retcode-check
Feb 18, 2026
Merged

OrdinaryDiffEq updates#276
benegee merged 13 commits intomainfrom
bg/fix-retcode-check

Conversation

@benegee
Copy link
Copy Markdown
Collaborator

@benegee benegee commented Feb 11, 2026

This PR originates from: https://github.com/trixi-framework/libtrixi/actions/runs/21808243190/job/62915273766#step:19:211

According to the docs (https://docs.sciml.ai/SciMLBase/stable/interfaces/Solutions/#SciMLBase.ReturnCode) the return code has be checked for success differently, and this is what I did.

I am not sure which version actually introduced the change which made the old check fail, nor do I know which version introduced support for the new check.
Instead, I decided to move to the split OrdinaryDiffEq packages, which I wanted to do at some point anyway.

Doing so, I realized we actually do not need OrdinaryDiffEq in LibTrixi.jl itself (just like with Trixi.jl).

Remaining questions @sloede

  1. Was there a reason to include OrdinaryDiffEq in LibTrixi.jl, which I do not remember?
  2. Are the precompilation setting
    [preferences.OrdinaryDiffEq]
    obsolete when using OrdinaryDiffEqLowStorageRK only?

CompatHelper Julia and others added 13 commits January 20, 2026 00:20
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.42.1 to 1.43.3.
- [Release notes](https://github.com/crate-ci/typos/releases)
- [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md)
- [Commits](crate-ci/typos@v1.42.1...v1.43.3)

---
updated-dependencies:
- dependency-name: crate-ci/typos
  dependency-version: 1.43.3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…-08-00-28-43-503-03382000766' into bg/fix-retcode-check
…-08-00-29-24-487-00230620603' into bg/fix-retcode-check
…-20-00-20-01-226-02439714846' into bg/fix-retcode-check
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.11%. Comparing base (3ed99f5) to head (cc92816).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files          25       25           
  Lines        1260     1260           
  Branches       74       74           
=======================================
  Hits         1211     1211           
  Misses         45       45           
  Partials        4        4           
Flag Coverage Δ
unittests 96.11% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benegee benegee changed the title Use recommended checking of return codes OrdinaryDiffEq updates Feb 12, 2026
@benegee benegee requested a review from sloede February 12, 2026 09:37
@sloede
Copy link
Copy Markdown
Member

sloede commented Feb 16, 2026

  • Was there a reason to include OrdinaryDiffEq in LibTrixi.jl, which I do not remember?

Not 100% sure to be honest 😅. I think it was such that you have all packages you might need installed - how would you do time integration from C/Fortran instead?

Yes, but I am not sure if there are similar preferences for the split packages (maybe ask in the Trixi channel or at the next meeting)

@benegee
Copy link
Copy Markdown
Collaborator Author

benegee commented Feb 17, 2026

Not 100% sure to be honest 😅. I think it was such that you have all packages you might need installed - how would you do time integration from C/Fortran instead?

Our libtrixi-init-julia script will always create a Julia project and add OrdinaryDiffEq* there, just like for the recommended run directory in Trixi.
But I am absolutely fine to have this as a direct dependency in the package itself.

Yes, but I am not sure if there are similar preferences for the split packages (maybe ask in the Trixi channel or at the next meeting)

As discussed on slack, there is no similar setting for split packages.

Copy link
Copy Markdown
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benegee benegee merged commit 4c32d0b into main Feb 18, 2026
12 checks passed
@benegee benegee deleted the bg/fix-retcode-check branch February 18, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants