This repository was archived by the owner on Oct 25, 2025. It is now read-only.
fix dnspod error: Communication with checkip server %s failed#526
Merged
troglobit merged 2 commits intotroglobit:masterfrom Oct 25, 2025
Merged
fix dnspod error: Communication with checkip server %s failed#526troglobit merged 2 commits intotroglobit:masterfrom
troglobit merged 2 commits intotroglobit:masterfrom
Conversation
Owner
|
Appreciate the analysis, I think you are spot on. Would you mind redoing the PR with your suggested change to: Lines 335 to 339 in 2a99888 |
Contributor
Author
|
Hi, I modified the condition from check ddns provider api server to checkip server name. |
troglobit
approved these changes
Oct 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin of dnspod had server_url = "". When I configured check_ip_server, the "get address from remote" function in ddns.c gets always returned.
static int get_address_remote(ddns_t *ctx, ddns_info_t *info, char *address, size_t len) { if (!info->server_url[0]) return 1;The easy fix is change empty string to "/" in dnspod plugin.
Well, I believe another fix to the IF-condition "if (!info->server_url[0])" should be done. Maybe some plugin has empty server_url but always has server_name.
static ddns_system_t plugin = { .server_name = "dnsapi.cn", .server_url = "" };Like as