Skip to content

Constify struct member and rm useless strdup(3). #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
younix wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Constify struct member and rm useless strdup(3). #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mcjoin.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,7 +774,7 @@ int main(int argc, char *argv[])
if (!g)
FATAL("failed allocating group: %s", strerror(errno));

g->group = strdup(DEFAULT_GROUP);
g->group = DEFAULT_GROUP;
TAILQ_INSERT_TAIL(&groups, g, entry);
group_num++;
}
Expand Down
4 changes: 2 additions & 2 deletions src/mcjoin.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ struct gr {
size_t order;
size_t delayed;
size_t invalid;
char *source;
char *group;
const char *source;
const char *group;
inet_addr_t src;
inet_addr_t grp; /* to */
size_t seqnos[STATUS_HISTORY]; /* for dup detection */
Expand Down