Continuation of #117 desired functionality#118
Open
RobertHerreraEECS wants to merge 1 commit intotrolldbois:masterfrom
Open
Continuation of #117 desired functionality#118RobertHerreraEECS wants to merge 1 commit intotrolldbois:masterfrom
RobertHerreraEECS wants to merge 1 commit intotrolldbois:masterfrom
Conversation
Modified get_unique_name to also account for a the parent node's typedef name, if one exists. This change is a continuation to trolldbois#117 where the edge cases arise if more than one level of anonymous typedef'd structs are embedded inside each other. - Helper function created to determine if parent typdef name exists.
Owner
|
@RobertHerreraEECS I really want to merge your pull request. But could you make up a unit test that would trigger edgecases you mention ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified get_unique_name to also account for a the parent node's typedef name, if one exists. This change is a continuation to #117 where an edge cases arises if more than one level of anonymous typedef'd structs are embedded inside each other.