fixup assertion calls

Author: zero-bites

test/integration/InvoiceLineSpec.ts

@@ -28,7 +28,7 @@ describe('InvoiceLine', () => {
         assert.ok(invoiceLines);
         assert.strictEqual(invoiceLines.length, 1);
         assert.strictEqual(invoiceLines[0].constructor, InvoiceLine);
-        assert.strictEqual('testInvoiceLine', invoiceLines[0].externalId);
+        assert.strictEqual(invoiceLines[0].externalId, 'testInvoiceLine');
     });
 
     it('updates an invoice line', async () => {
@@ -56,7 +56,7 @@ describe('InvoiceLine', () => {
         assert.strictEqual(invoiceLines.length, 1);
         assert.strictEqual(invoiceLines[0].constructor, InvoiceLine);
         assert.strictEqual(updatedInvoice.lines.length, 1);
-        assert.strictEqual('updated line description', updatedInvoice.lines[0].description);
+        assert.strictEqual(updatedInvoice.lines[0].description, 'updated line description');
     });
 
     it('deletes an invoice line', async () => {

test/integration/InvoiceSpec.ts

@@ -25,7 +25,7 @@ describe("Invoice", () => {
 
         assert.ok(invoice);
         assert.strictEqual(invoice.constructor, Invoice);
-        assert.strictEqual("testInvoice", invoice.externalId);
+        assert.strictEqual(invoice.externalId, "testInvoice");
         assert.strictEqual(recipient.id, invoice.recipientId);
     });
 
@@ -55,10 +55,10 @@ describe("Invoice", () => {
 
         assert.ok(invoice);
         assert.strictEqual(invoice.constructor, Invoice);
-        assert.strictEqual("testInvoice", invoice.externalId);
+        assert.strictEqual(invoice.externalId, "testInvoice");
         assert.strictEqual(recipient.id, invoice.recipientId);
-        assert.strictEqual(1, invoice.lines.length);
-        assert.strictEqual("testInvoiceLine", invoice.lines[0].externalId);
+        assert.strictEqual(invoice.lines.length, 1);
+        assert.strictEqual(invoice.lines[0].externalId, "testInvoiceLine");
 
     });
 
@@ -76,7 +76,7 @@ describe("Invoice", () => {
 
         assert.ok(findInvoice);
         assert.strictEqual(findInvoice.constructor, Invoice);
-        assert.strictEqual("testInvoice", findInvoice.externalId);
+        assert.strictEqual(findInvoice.externalId, "testInvoice");
     });
 
     it("searches for an invoice", async () => {
@@ -125,7 +125,7 @@ describe("Invoice", () => {
 
         assert.ok(invoice);
         assert.strictEqual(invoice.constructor, Invoice);
-        assert.strictEqual("Updated description", updatedInvoice.description);
+        assert.strictEqual(updatedInvoice.description, "Updated description");
     });
 
     it("deletes an invoice", async () => {

test/integration/OfflinePaymentSpec.ts

@@ -47,7 +47,7 @@ describe('OfflinePayment', () => {
 
         assert.ok(offlinePayment);
         assert.strictEqual(offlinePayment.constructor, OfflinePayment);
-        assert.strictEqual(true, offlinePayment.taxReportable);
+        assert.strictEqual(offlinePayment.taxReportable, true);
     });
 
     it('deletes an offline payment', async () => {
@@ -88,7 +88,7 @@ describe('OfflinePayment', () => {
         nockDone();
 
         assert.ok(offlinePaymentResults);
-        assert.strictEqual(2, offlinePaymentResults.length);
+        assert.strictEqual(offlinePaymentResults.length, 2);
         assert.strictEqual(offlinePaymentResults[0].constructor, OfflinePayment);
         assert.strictEqual(offlinePaymentResults[1].constructor, OfflinePayment);
     });

test/integration/PaymentSpec.ts

@@ -71,7 +71,7 @@ describe('Payment', () => {
 
         assert.ok(updatedPayment);
         assert.strictEqual(updatedPayment.constructor, Payment);
-        assert.strictEqual('updatedPayment', updatedPayment.externalId);
+        assert.strictEqual(updatedPayment.externalId, 'updatedPayment');
     });
 
     it('deletes a payment', async () => {
@@ -96,7 +96,7 @@ describe('Payment', () => {
         nockDone();
 
         assert.ok(deletedPaymentResult);
-        assert.strictEqual(true, deletedPaymentResult);
+        assert.strictEqual(deletedPaymentResult, true);
     });
 
     it('searches for a payment', async () => {
@@ -123,7 +123,7 @@ describe('Payment', () => {
         nockDone();
 
         assert.ok(paymentsCollection);
-        assert.strictEqual(1, paymentsCollection.length);
+        assert.strictEqual(paymentsCollection.length, 1);
         assert.strictEqual(paymentsCollection[0].constructor, Payment);
         assert.strictEqual(payment.externalId, paymentsCollection[0].externalId);
     });

test/integration/RecipientAccountSpec.ts

@@ -55,7 +55,7 @@ describe("RecipientAccount", () => {
         assert.strictEqual(accountList2.length, 1);
         assert.strictEqual(accountList2[0].id, account2.id);
 
-        assert.strictEqual(true, deleteResult);
+        assert.strictEqual(deleteResult, true);
 
         assert.strictEqual(accountList2.length, 1);
         assert.ok(accountList2[0].primary);
@@ -99,13 +99,13 @@ describe("RecipientAccount", () => {
         const account = await recipientAccountFactory.createResource({
             recipient: { id: recipient.id },
         });
-        const result = await testingApiClient.recipientAccount.remove(recipient.id, account.id);
+        const deleteResult = await testingApiClient.recipientAccount.remove(recipient.id, account.id);
         const accountList = await testingApiClient.recipientAccount.all(recipient.id);
 
         nockDone();
 
         assert.ok(account);
-        assert.strictEqual(true, result);
+        assert.strictEqual(deleteResult, true);
         assert.strictEqual(accountList.length, 0);
     });
 

test/integration/RecipientSpec.ts

@@ -16,10 +16,10 @@ describe("Recipient", () => {
     const recipient = await recipientFactory.createResource();
 
     assert.ok(recipient);
-    assert.strictEqual(recipient.constructor, Recipient);
-    assert.strictEqual("Tom", recipientFactory.defaultAttrs.firstName);
-    assert.strictEqual("Jones", recipientFactory.defaultAttrs.lastName);
     assert.ok(recipient.id);
+    assert.strictEqual(recipient.constructor, Recipient);
+    assert.strictEqual(recipientFactory.defaultAttrs.firstName, "Tom");
+    assert.strictEqual(recipientFactory.defaultAttrs.lastName, "Jones");
 
     nockDone();
   });
@@ -37,8 +37,8 @@ describe("Recipient", () => {
 
     assert.ok(updatedRecipient);
     assert.strictEqual(updatedRecipient.constructor, Recipient);
-    assert.strictEqual("John", updatedRecipient.firstName);
-    assert.strictEqual("Smith", updatedRecipient.lastName);
+    assert.strictEqual(updatedRecipient.firstName, "John");
+    assert.strictEqual(updatedRecipient.lastName, "Smith");
     });
 
   it("deletes a recipient", async () => {
@@ -61,7 +61,7 @@ describe("Recipient", () => {
     nockDone();
 
     assert.ok(recipientsCollection);
-    assert.strictEqual(1, recipientsCollection.length);
+    assert.strictEqual(recipientsCollection.length, 1);
     assert.strictEqual(recipient.id, recipientsCollection[0].id);
     });
   });