Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes MbedTLS v4 integration by updating the submodule reference and adding required platform-specific implementations for STM32, including time and entropy functions, along with proper RNG initialization.
Key Changes
- Updated libtropic submodule to a new commit
- Added MbedTLS platform implementation file for STM32 (time and entropy functions)
- Added comprehensive MbedTLS and PSA crypto configuration files
- Modified main application to properly initialize and use RNG peripheral
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vendor/libtropic | Updated submodule commit reference |
| NUCLEO_F439ZI/Src/mbedtls_v4/mbedtls_platform.c | New platform-specific MbedTLS implementations for STM32 |
| NUCLEO_F439ZI/Src/mbedtls_v4/mbedtls_config.h | New MbedTLS configuration file |
| NUCLEO_F439ZI/Src/mbedtls_v4/crypto_config.h | New PSA crypto configuration file |
| NUCLEO_F439ZI/Src/main.c | Updated to initialize RNG and use pointer to RNG handle |
| NUCLEO_F439ZI/Inc/main.h | Added RNG handle declaration |
| NUCLEO_F439ZI/CMakeLists.txt | Updated build configuration for MbedTLS with custom config files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| set(MBEDTLS_CONFIG_FILE "${CMAKE_CURRENT_SOURCE_DIR}/Src/mbedtls_v4/mbedtls_config.h") | ||
| set(TF_PSA_CRYPTO_CONFIG_FILE "${CMAKE_CURRENT_SOURCE_DIR}/Src/mbedtls_v4/crypto_config.h") |
There was a problem hiding this comment.
Why are the values set if not used anywhere?
There was a problem hiding this comment.
I added explanation and also reused this value
Note: README is edited in #49 already, not fixing here