ETR01SDK-459: Enhance deinitialization on errors#409
Closed
Copilot wants to merge 1 commit intoETR01SDK-459-Enhance-deinitialization-on-errorsfrom
Closed
ETR01SDK-459: Enhance deinitialization on errors#409Copilot wants to merge 1 commit intoETR01SDK-459-Enhance-deinitialization-on-errorsfrom
Copilot wants to merge 1 commit intoETR01SDK-459-Enhance-deinitialization-on-errorsfrom
Conversation
15 tasks
Copilot
AI
changed the title
[WIP] Enhance deinitialization on errors
ETR01SDK-459: Enhance deinitialization on errors
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Answered code review question about secure memory zeroing coverage. After comprehensive analysis of cryptographic code paths, confirmed that existing secure zeroing implementation is complete:
lt_hkdf(): zeros HMAC-SHA256 intermediate buffers (tmp,helper)lt_in__session_start(): zeros key derivation intermediates and session keys (output_1,output_2,shared_secret,hash,kcmd,kres,kauth)lt_session_start(): zeros ephemeral keys (host_eph_keys)No additional code changes required.
Type of Change
Select the type(s) that best describe your change:
Checklist
Before submitting, please confirm that you have completed the following:
Optional Checks
You can enable optional CI jobs by checking following boxes. For example, coverage job is useful when modifying or implementing new tests.
Notes for Reviewers
The secure memory zeroing implementation covers all critical paths where cryptographic material is stored in local variables. No additional locations require zeroing beyond what's already implemented.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.