ETR01SDK-544: Fix strict compilation target paths#449
Merged
andreondra merged 1 commit intodevelopfrom Feb 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the paths used when applying strict compilation flags in CMake configuration files. The issue was that some test directories were referencing hardcoded file paths instead of using the already-defined ${SOURCES} variable, and one path was incorrect (referencing a non-existent src/main.c file).
Changes:
- Updated four CMakeLists.txt/common.cmake files to use
${SOURCES}variable instead of hardcoded paths when setting strict compilation properties - Fixed incorrect path reference in usb_devkit that pointed to non-existent
src/main.c
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/functional/model/CMakeLists.txt | Changed strict compilation flags to use ${SOURCES} instead of hardcoded main.c path |
| tests/functional/linux/usb_devkit/CMakeLists.txt | Fixed incorrect src/main.c reference and changed to use ${SOURCES} variable |
| tests/functional/linux/spi/CMakeLists.txt | Changed strict compilation flags to use ${SOURCES} instead of hardcoded main.c path |
| tests/functional/esp32/common.cmake | Changed strict compilation flags to use ${SOURCES} instead of hardcoded main.c path |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
medexs
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR I fix paths of files on which we apply strict compilation flags.
Type of Change
Select the type(s) that best describe your change:
Checklist
Before submitting, please confirm that you have completed the following:
Optional Checks
You can enable optional CI jobs by checking following boxes. For example, coverage job is useful when modifying or implementing new tests.