Skip to content

ETR01SDK-544: Fix strict compilation target paths#449

Merged
andreondra merged 1 commit intodevelopfrom
ETR01SDK-544-Fix-strict-compilation-target-paths
Feb 4, 2026
Merged

ETR01SDK-544: Fix strict compilation target paths#449
andreondra merged 1 commit intodevelopfrom
ETR01SDK-544-Fix-strict-compilation-target-paths

Conversation

@andreondra
Copy link
Contributor

@andreondra andreondra commented Feb 4, 2026

Description

In this PR I fix paths of files on which we apply strict compilation flags.


Type of Change

Select the type(s) that best describe your change:

  • 🐛 Bug fix
  • ✨ New feature
  • 🧹 Code cleanup or refactoring
  • 📝 Documentation update
  • 🔧 Build system or toolchain update
  • 🔒 Security improvement
  • Other (please describe):

Checklist

Before submitting, please confirm that you have completed the following:

  • I opened the Pull Request to the develop branch
  • I followed the project's code guidelines
  • I formatted the code using clang-format with the recommended configuration
  • I updated the changelog, or this change does not require it (e.g., internal or non-functional update)
  • The project builds without errors or warnings
  • I have verified the functionality against the hardware/model as applicable
  • I have ensured that public APIs remain backward compatible (if applicable)
  • This PR is ready for review by maintainers (no WIP commits left) and marked as Ready for Review

Optional Checks

You can enable optional CI jobs by checking following boxes. For example, coverage job is useful when modifying or implementing new tests.

  • Measure Test Coverage

@andreondra andreondra requested a review from Copilot February 4, 2026 09:58
@andreondra andreondra self-assigned this Feb 4, 2026
@andreondra andreondra added bug Something isn't working functional tests New or modified functional tests labels Feb 4, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the paths used when applying strict compilation flags in CMake configuration files. The issue was that some test directories were referencing hardcoded file paths instead of using the already-defined ${SOURCES} variable, and one path was incorrect (referencing a non-existent src/main.c file).

Changes:

  • Updated four CMakeLists.txt/common.cmake files to use ${SOURCES} variable instead of hardcoded paths when setting strict compilation properties
  • Fixed incorrect path reference in usb_devkit that pointed to non-existent src/main.c

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tests/functional/model/CMakeLists.txt Changed strict compilation flags to use ${SOURCES} instead of hardcoded main.c path
tests/functional/linux/usb_devkit/CMakeLists.txt Fixed incorrect src/main.c reference and changed to use ${SOURCES} variable
tests/functional/linux/spi/CMakeLists.txt Changed strict compilation flags to use ${SOURCES} instead of hardcoded main.c path
tests/functional/esp32/common.cmake Changed strict compilation flags to use ${SOURCES} instead of hardcoded main.c path

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@andreondra andreondra requested a review from medexs February 4, 2026 10:02
@andreondra andreondra marked this pull request as ready for review February 4, 2026 10:02
@andreondra andreondra merged commit f9987b7 into develop Feb 4, 2026
16 checks passed
@andreondra andreondra deleted the ETR01SDK-544-Fix-strict-compilation-target-paths branch February 4, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working functional tests New or modified functional tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants