ETR01SDK-430: Fixed l3_chunk size in lt_l2_encrypted_cmd_*#451
Conversation
|
Valgrind CI fails because of some problem with packages. I think that's out of scope of this PR. Edit: solved in #453 |
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the L2 API struct definitions where the l3_chunk array size was hardcoded to 255 bytes instead of using the correct API-specified constant TR01_L2_CHUNK_MAX_DATA_SIZE (252 bytes). The hardcoded value was inconsistent with the TROPIC01 hardware API specification and with the actual usage throughout the codebase, where the constant was already being used for chunk size calculations.
Changes:
- Updated
lt_l2_encrypted_cmd_req_tstruct to useTR01_L2_CHUNK_MAX_DATA_SIZEinstead of hardcoded 255 - Updated
lt_l2_encrypted_cmd_rsp_tstruct to useTR01_L2_CHUNK_MAX_DATA_SIZEinstead of hardcoded 255 - Added changelog entry documenting the change
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/lt_l2_api_structs.h | Fixed l3_chunk array size in both request and response structs to use the correct constant (252) instead of hardcoded value (255) |
| CHANGELOG.md | Added entry for version 3.2.0 documenting the struct size change (with minor typo) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Use correct size of the
l3_chunkmember according to the TROPIC01 API.Type of Change
Select the type(s) that best describe your change:
Checklist
Before submitting, please confirm that you have completed the following:
Optional Checks
You can enable optional CI jobs by checking following boxes. For example, coverage job is useful when modifying or implementing new tests.