ETR01SDK-429: check logic of low level l2 functions buff len checking#455
Merged
andreondra merged 5 commits intodevelopfrom Feb 6, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds missing buffer length checking to the lt_session_start function and improves comment consistency in libtropic_l2.c by standardizing protocol layer references to use uppercase (L2/L3 instead of l2/l3).
Changes:
- Added response length validation check in
lt_session_startto verify the handshake response length matches the expected value - Standardized comments in
libtropic_l2.cto use uppercase L2/L3 notation consistently
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/libtropic.c | Added buffer length check for handshake response in lt_session_start function |
| src/libtropic_l2.c | Improved comment consistency by standardizing L2/L3 capitalization and clarifying wording |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
medexs
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As a part of this PR I went through both API and low-level functions and verified implementation of buffer length checking. I found one place where the check was not implemented. I also enhanced some comments in
libtropic_l2.c.Type of Change
Select the type(s) that best describe your change:
Checklist
Before submitting, please confirm that you have completed the following:
Optional Checks
You can enable optional CI jobs by checking following boxes. For example, coverage job is useful when modifying or implementing new tests.