[4.0.0] [WIP] ETR01SDK-584: Refactor lt_ecc_ecdsa_sign (remove hashing)#476
Draft
andreondra wants to merge 4 commits intodevelopfrom
Draft
[4.0.0] [WIP] ETR01SDK-584: Refactor lt_ecc_ecdsa_sign (remove hashing)#476andreondra wants to merge 4 commits intodevelopfrom
lt_ecc_ecdsa_sign (remove hashing)#476andreondra wants to merge 4 commits intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As this PR changes the API behavior, it is draft until 4.0.0 release.
In this PR, I remove hashing from
lt_ecc_ecdsa_sign. I also fix relevant test.Type of Change
Select the type(s) that best describe your change:
Checklist
Before submitting, please confirm that you have completed the following:
Optional Checks
You can enable optional CI jobs by checking following boxes. For example, coverage job is useful when modifying or implementing new tests.