Skip to content

Conversation

@ryanwelcher
Copy link
Collaborator

@ryanwelcher ryanwelcher commented Jun 17, 2025

Description

If the plugin is activated before composer install is run, it will fire an error. This PR adds a check and triggers a warning to the user.

Related Issue

Closes #18

Testing Instructions

  1. Remove the vendor dir on main branch and activate the plugin.
  2. Confirm there is a fatal error
  3. Switch to this branch and try to activate
  4. Confirm that WordPress still loads but a warning is fired telling the user to run composer install

Checklist

  • Have you added a note to the changelog?
  • Have you ensured the code passes all tests using the included plugin-check?
  • Have you checked for code style and linting errors?

@ryanwelcher ryanwelcher requested a review from troychaplin June 17, 2025 15:31
@ryanwelcher ryanwelcher added the enhancement New feature or request label Jun 17, 2025
Copy link
Owner

@troychaplin troychaplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never considered this as I always had a vendor folder. I think it might be best to commit the vendor folder and avoid this setup altogether.

@troychaplin troychaplin merged commit 737d72f into main Jun 19, 2025
1 check passed
@troychaplin troychaplin deleted the fix/check-for-autoload branch July 25, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need to run composer install before trying to start the local env

3 participants