tool: add openapi tool #719
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangxuw
force-pushed
the
feat_tool_openapi
branch
from
cba5853 to
dba839e
Compare
WineChord
reviewed
Nov 24, 2025
| if !ok { | ||
| continue | ||
| } | ||
| switch param.Location { |
Contributor
There was a problem hiding this comment.
这里你收集了四种 params，但是后面只用到了 path params
WineChord
reviewed
Nov 24, 2025
| if param == nil { | ||
| continue | ||
| } | ||
| pv := param.Value |
WineChord
reviewed
Nov 24, 2025
|
|
||
| func (s *specProcessor) processOperations() error { | ||
| if len(s.doc.Servers) == 0 { | ||
| return fmt.Errorf("no server defined") |
Contributor
There was a problem hiding this comment.
这里有点严格了，根据规范，没提供 servers 的时候默认 / 就好，而且你下面默认只用第 0 个 servers 应该也不太合理。
https://swagger.io/docs/specification/v3_0/api-host-and-base-path/
WineChord
reviewed
Nov 24, 2025
| name: "create_toolset_ok_uri", | ||
| args: args{ | ||
| opts: []Option{ | ||
| WithSpecLoader(NewURILoader("https://petstore3.swagger.io/api/v3/openapi.json")), |
Contributor
There was a problem hiding this comment.
测试建议不要依赖公网资源，否则 ci 不稳定。可以在本地做一个 testdata 文件
WineChord
reviewed
Nov 24, 2025
| } | ||
| } | ||
| } | ||
| o.responseParam = &APIParameter{ |
Contributor
There was a problem hiding this comment.
这里构造了 responseParam，toolOutputSchema() 那边为什么不用呢？
WineChord
reviewed
Nov 24, 2025
| // openAPIToolSet is a set of tools. | ||
| type openAPIToolSet struct { | ||
| spec *specProcessor | ||
| name string |
Contributor
There was a problem hiding this comment.
这个 name 可以考虑给一个默认值，目前默认为空的话，NamedToolSet 那边不会给 Tool 名加前缀。
WineChord
reviewed
Nov 24, 2025
| func makeRequestURL(endpoint *operationEndpoint, pathParams map[string]any) string { | ||
| endpointURL := endpoint.baseURL + endpoint.path | ||
| for arg, value := range pathParams { | ||
| endpointURL = strings.ReplaceAll(endpointURL, fmt.Sprintf("{%s}", arg), fmt.Sprintf("%v", value)) |
Contributor
There was a problem hiding this comment.
这里要用 url.URL / url.PathEscape 做路径和参数转义。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add openapi tool