allow user format mcp content #733
Open
+26
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
bytethm
reviewed
Nov 24, 2025
| // - error: if not nil, this error will be returned. | ||
| type AfterToolCallback func(ctx context.Context, toolName string, toolDeclaration *Declaration, jsonArgs []byte, result any, runErr error) (any, error) | ||
|
|
||
| type Message any // should be model.Message, avoid cycle import |
Contributor
There was a problem hiding this comment.
这个导出字段需要加一下注释 // Message ...
bytethm
reviewed
Nov 24, 2025
| // Marshal the result to JSON. | ||
| resultBytes, err := json.Marshal(result) | ||
| format := toolJsonContent | ||
| if p.toolCallbacks.ToolFormatMessage != nil { |
Contributor
There was a problem hiding this comment.
p.toolCallbacks 可能是 nil，得判断一下
bytethm
reviewed
Nov 24, 2025
| ToolID: toolCall.ID, | ||
| }, | ||
| Index: index, | ||
| Message: msg.(model.Message), |
Contributor
There was a problem hiding this comment.
如果业务实现 callback 不是规范的 model.Message，这里可能会 panic。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.