Skip to content

#22: + Fix test failures after API function renaming #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EdmondDantes merged 1 commit into from
Jul 11, 2025
Merged

#22: + Fix test failures after API function renaming #29

EdmondDantes merged 1 commit into from
Jul 11, 2025

Conversation

@EdmondDantes
Copy link
Contributor

@EdmondDantes EdmondDantes commented Jul 11, 2025 

     - Fix typo "awaitAllOrFailOrFail" → "awaitAllOrFail" in bailout test
     - Remove duplicate import statements in test files
     - Update all .phpt tests to use new awaitAll() return format [results, exceptions]
     - Fix DNS tests to properly count results with new API structure
     - Update empty iterator tests for new tuple return format
     - Update CHANGELOG.md with API breaking changes documentation

     Breaking changes documented:
     - awaitAllFailFirst() → awaitAllOrFail()
     - awaitAllWithErrors() → awaitAll()
     - awaitAnyOfFailFirst() → awaitAnyOfOrFail()
     - awaitAnyOfWithErrors() → awaitAnyOf()
     - awaitAll() now returns [results, exceptions] tuple

@EdmondDantes
#22: + Fix test failures after API function renaming
32d358b 
         - Fix typo "awaitAllOrFailOrFail" → "awaitAllOrFail" in bailout test
         - Remove duplicate import statements in test files
         - Update all .phpt tests to use new awaitAll() return format [results, exceptions]
         - Fix DNS tests to properly count results with new API structure
         - Update empty iterator tests for new tuple return format
         - Update CHANGELOG.md with API breaking changes documentation

         Breaking changes documented:
         - awaitAllFailFirst() → awaitAllOrFail()
         - awaitAllWithErrors() → awaitAll()
         - awaitAnyOfFailFirst() → awaitAnyOfOrFail()
         - awaitAnyOfWithErrors() → awaitAnyOf()
         - awaitAll() now returns [results, exceptions] tuple
@EdmondDantes EdmondDantes linked an issue Jul 11, 2025 that may be closed by this pull request
Revise the awaitAll methods and others according to the principle of least astonishment. #22
Closed
@EdmondDantes EdmondDantes self-assigned this Jul 11, 2025
@EdmondDantes EdmondDantes added the enhancement New feature or request label Jul 11, 2025
@EdmondDantes EdmondDantes added this to the Stabilization milestone Jul 11, 2025
@EdmondDantes EdmondDantes merged commit 9c094e3 into main Jul 11, 2025
1 check passed
@EdmondDantes EdmondDantes deleted the 22-revise-the-awaitall-methods-and-others-according-to-the-principle-of-least-astonishment branch July 11, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@EdmondDantes EdmondDantes

Labels

enhancement New feature or request

Projects

None yet

Milestone

Stabilization

Development

Successfully merging this pull request may close these issues.

Revise the awaitAll methods and others according to the principle of least astonishment.

2 participants

@EdmondDantes