50 performance optimizations

async.c

@@ -141,6 +141,7 @@ PHP_FUNCTION(Async_suspend)
 	THROW_IF_SCHEDULER_CONTEXT;
 	ZEND_ASYNC_ENQUEUE_COROUTINE(ZEND_ASYNC_CURRENT_COROUTINE);
 	ZEND_ASYNC_SUSPEND();
+	zend_async_waker_clean(ZEND_ASYNC_CURRENT_COROUTINE);
 }
 
 PHP_FUNCTION(Async_protect)
@@ -277,6 +278,7 @@ PHP_FUNCTION(Async_await)
 	ZEND_ASYNC_SUSPEND();
 
 	if (UNEXPECTED(EG(exception) != NULL)) {
+		zend_async_waker_clean(coroutine);
 		RETURN_THROWS();
 	}
 
@@ -288,7 +290,7 @@ PHP_FUNCTION(Async_await)
 		ZVAL_COPY(return_value, &coroutine->waker->result);
 	}
 
-	zend_async_waker_destroy(coroutine);
+	zend_async_waker_clean(coroutine);
 }
 
 PHP_FUNCTION(Async_awaitAnyOrFail)
@@ -609,7 +611,7 @@ PHP_FUNCTION(Async_delay)
 
 	ZEND_ASYNC_SUSPEND();
 
-	zend_async_waker_destroy(coroutine);
+	zend_async_waker_clean(coroutine);
 }
 
 PHP_FUNCTION(Async_timeout)

async_API.c

@@ -824,6 +824,7 @@ static void async_cancel_awaited_futures(async_await_context_t *await_context, H
 	}
 
 	ZEND_ASYNC_SUSPEND();
+	zend_async_waker_clean(ZEND_ASYNC_CURRENT_COROUTINE);
 }
 
 /**
@@ -1044,6 +1045,7 @@ void async_await_futures(zval *iterable,
 
 	if (coroutine->waker->events.nNumOfElements > 0) {
 		ZEND_ASYNC_SUSPEND();
+		zend_async_waker_clean(ZEND_ASYNC_CURRENT_COROUTINE);
 	}
 
 	// If the await on futures has completed and

benchmarks/compare_results.php

@@ -0,0 +1,144 @@
+<?php
+/**
+ * Comparison script for Coroutines vs Fibers benchmarks
+ * Run both benchmarks and compare results
+ */
+
+// Increase memory limit for benchmark
+ini_set('memory_limit', '512M');
+
+echo "=== Coroutines vs Fibers Comparison ===\n\n";
+
+// Configuration
+$iterations = 1000;
+$switches = 50;
+
+echo "Configuration:\n";
+echo "- Iterations: $iterations\n";
+echo "- Switches per iteration: $switches\n";
+echo "- Total context switches: " . ($iterations * $switches) . "\n\n";
+
+// Function to run external benchmark and capture output
+function runBenchmark($script) {
+    $output = [];
+    $return_var = 0;
+    exec("php " . __DIR__ . "/$script 2>&1", $output, $return_var);
+    return [
+        'output' => implode("\n", $output),
+        'success' => $return_var === 0
+    ];
+}
+
+// Function to parse benchmark results from output
+function parseResults($output) {
+    $results = [];
+
+    if (preg_match('/Time: ([0-9.]+) seconds/', $output, $matches)) {
+        $results['time'] = (float)$matches[1];
+    }
+
+    if (preg_match('/Switches per second: ([0-9,]+)/', $output, $matches)) {
+        $results['switches_per_sec'] = (int)str_replace(',', '', $matches[1]);
+    }
+
+    if (preg_match('/Overhead per switch: ([0-9.]+) μs/', $output, $matches)) {
+        $results['overhead_us'] = (float)$matches[1];
+    }
+
+    if (preg_match('/Used for benchmark: ([0-9.]+) MB/', $output, $matches)) {
+        $results['memory_mb'] = (float)$matches[1];
+    }
+
+    return $results;
+}
+
+echo "Running coroutines benchmark...\n";
+$coroutineResult = runBenchmark('coroutines_benchmark.php');
+
+echo "Running fibers benchmark...\n";
+$fiberResult = runBenchmark('fibers_benchmark.php');
+
+echo "\n" . str_repeat("=", 60) . "\n";
+echo "COMPARISON RESULTS\n";
+echo str_repeat("=", 60) . "\n\n";
+
+if (!$coroutineResult['success']) {
+    echo "❌ Coroutines benchmark failed:\n";
+    echo $coroutineResult['output'] . "\n\n";
+} else {
+    echo "✅ Coroutines benchmark completed successfully\n\n";
+}
+
+if (!$fiberResult['success']) {
+    echo "❌ Fibers benchmark failed:\n";
+    echo $fiberResult['output'] . "\n\n";
+} else {
+    echo "✅ Fibers benchmark completed successfully\n\n";
+}
+
+// Parse and compare results if both succeeded
+if ($coroutineResult['success'] && $fiberResult['success']) {
+    $coroutineStats = parseResults($coroutineResult['output']);
+    $fiberStats = parseResults($fiberResult['output']);
+
+    echo "📊 PERFORMANCE COMPARISON:\n\n";
+
+    // Time comparison
+    if (isset($coroutineStats['time']) && isset($fiberStats['time'])) {
+        $timeRatio = $fiberStats['time'] / $coroutineStats['time'];
+        echo "⏱️  Execution Time:\n";
+        echo "   Coroutines: " . number_format($coroutineStats['time'], 4) . "s\n";
+        echo "   Fibers:     " . number_format($fiberStats['time'], 4) . "s\n";
+        if ($timeRatio > 1) {
+            echo "   🏆 Coroutines are " . number_format($timeRatio, 2) . "x faster\n\n";
+        } else {
+            echo "   🏆 Fibers are " . number_format(1/$timeRatio, 2) . "x faster\n\n";
+        }
+    }
+
+    // Throughput comparison
+    if (isset($coroutineStats['switches_per_sec']) && isset($fiberStats['switches_per_sec'])) {
+        echo "🚀 Throughput (switches/sec):\n";
+        echo "   Coroutines: " . number_format($coroutineStats['switches_per_sec']) . "\n";
+        echo "   Fibers:     " . number_format($fiberStats['switches_per_sec']) . "\n";
+        $throughputRatio = $coroutineStats['switches_per_sec'] / $fiberStats['switches_per_sec'];
+        if ($throughputRatio > 1) {
+            echo "   🏆 Coroutines have " . number_format($throughputRatio, 2) . "x higher throughput\n\n";
+        } else {
+            echo "   🏆 Fibers have " . number_format(1/$throughputRatio, 2) . "x higher throughput\n\n";
+        }
+    }
+
+    // Overhead comparison
+    if (isset($coroutineStats['overhead_us']) && isset($fiberStats['overhead_us'])) {
+        echo "⚡ Overhead per switch:\n";
+        echo "   Coroutines: " . number_format($coroutineStats['overhead_us'], 2) . " μs\n";
+        echo "   Fibers:     " . number_format($fiberStats['overhead_us'], 2) . " μs\n";
+        $overheadRatio = $fiberStats['overhead_us'] / $coroutineStats['overhead_us'];
+        if ($overheadRatio > 1) {
+            echo "   🏆 Coroutines have " . number_format($overheadRatio, 2) . "x lower overhead\n\n";
+        } else {
+            echo "   🏆 Fibers have " . number_format(1/$overheadRatio, 2) . "x lower overhead\n\n";
+        }
+    }
+
+    // Memory comparison
+    if (isset($coroutineStats['memory_mb']) && isset($fiberStats['memory_mb'])) {
+        echo "💾 Memory Usage:\n";
+        echo "   Coroutines: " . number_format($coroutineStats['memory_mb'], 2) . " MB\n";
+        echo "   Fibers:     " . number_format($fiberStats['memory_mb'], 2) . " MB\n";
+        $memoryRatio = $fiberStats['memory_mb'] / $coroutineStats['memory_mb'];
+        if ($memoryRatio > 1) {
+            echo "   🏆 Coroutines use " . number_format($memoryRatio, 2) . "x less memory\n\n";
+        } else {
+            echo "   🏆 Fibers use " . number_format(1/$memoryRatio, 2) . "x less memory\n\n";
+        }
+    }
+} else {
+    echo "⚠️  Cannot compare results - one or both benchmarks failed\n";
+}
+
+echo "💡 Note: Results may vary based on system load and configuration\n";
+echo "💡 Run multiple times and average results for production comparisons\n";
+
+echo "\nComparison completed.\n";

benchmarks/coroutines_benchmark.php

@@ -0,0 +1,102 @@
+<?php
+/**
+ * Benchmark: Async Coroutines switching performance
+ * Tests the performance of async coroutines context switching
+ */
+
+// Increase memory limit for benchmark
+ini_set('memory_limit', '512M');
+
+use function Async\spawn;
+use function Async\awaitAll;
+
+echo "=== Async Coroutines Benchmark ===\n\n";
+
+// Test configuration
+$iterations = 1000;
+$switches = 1000;
+
+// Benchmark async coroutines
+function benchmarkCoroutines($iterations, $switches) {
+    $start = microtime(true);
+    $memoryBeforeCreate = getCurrentMemoryUsage();
+
+    $coroutines = [];
+    for ($i = 0; $i < $iterations; $i++) {
+        $coroutines[] = spawn(function() use ($switches) {
+            for ($j = 0; $j < $switches; $j++) {
+                // Yield control to other coroutines
+                Async\suspend();
+            }
+        });
+    }
+
+    $memoryAfterCreate = getCurrentMemoryUsage();
+
+    awaitAll($coroutines);
+
+    $end = microtime(true);
+    return [
+        'time' => $end - $start,
+        'memoryBeforeCreate' => $memoryBeforeCreate,
+        'memoryAfterCreate' => $memoryAfterCreate,
+        'creationOverhead' => $memoryAfterCreate - $memoryBeforeCreate
+    ];
+}
+
+// Memory usage tracking
+function getCurrentMemoryUsage() {
+    return memory_get_usage(true);
+}
+
+function getPeakMemoryUsage() {
+    return memory_get_peak_usage(true);
+}
+
+// Run benchmark
+echo "Configuration:\n";
+echo "- Iterations: $iterations\n";
+echo "- Switches per iteration: $switches\n";
+echo "- Total context switches: " . ($iterations * $switches) . "\n\n";
+
+// Memory usage before benchmark
+$memoryBefore = getCurrentMemoryUsage();
+
+// Warmup
+echo "Warming up...\n";
+benchmarkCoroutines(100, 10);
+
+echo "\nRunning coroutines benchmark...\n";
+
+// Benchmark coroutines
+$result = benchmarkCoroutines($iterations, $switches);
+$coroutineTime = $result['time'];
+
+// Memory usage after benchmark
+$memoryAfter = getCurrentMemoryUsage();
+$memoryPeak = getPeakMemoryUsage();
+
+// Results
+echo "\n=== Results ===\n";
+echo "Time: " . number_format($coroutineTime, 4) . " seconds\n";
+echo "Switches per second: " . number_format(($iterations * $switches) / $coroutineTime, 0) . "\n";
+echo "Overhead per switch: " . number_format(($coroutineTime / ($iterations * $switches)) * 1000000, 2) . " μs\n";
+
+echo "\nMemory Usage:\n";
+echo "Before: " . number_format($memoryBefore / 1024 / 1024, 2) . " MB\n";
+echo "After creation: " . number_format($result['memoryAfterCreate'] / 1024 / 1024, 2) . " MB\n";
+echo "After completion: " . number_format($memoryAfter / 1024 / 1024, 2) . " MB\n";
+echo "Peak: " . number_format($memoryPeak / 1024 / 1024, 2) . " MB\n";
+echo "Creation overhead: " . number_format($result['creationOverhead'] / 1024 / 1024, 2) . " MB\n";
+echo "Used for benchmark: " . number_format(($memoryAfter - $memoryBefore) / 1024 / 1024, 2) . " MB\n";
+
+// Additional metrics
+$totalSwitches = $iterations * $switches;
+echo "\nPerformance Metrics:\n";
+echo "Total coroutines created: $iterations\n";
+echo "Total context switches: $totalSwitches\n";
+echo "Average time per coroutine: " . number_format($coroutineTime / $iterations * 1000, 2) . " ms\n";
+echo "Memory per coroutine (creation): " . number_format($result['creationOverhead'] / $iterations, 0) . " bytes\n";
+echo "Memory per coroutine (total): " . number_format(($memoryAfter - $memoryBefore) / $iterations, 0) . " bytes\n";
+
+echo "\nCoroutines benchmark completed.\n";