-
-
Notifications
You must be signed in to change notification settings - Fork 613
Fix test failures from removed image references #44932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -236,7 +236,7 @@ command: | |||||
| {{- define "tc.v1.common.lib.deps.wait.clickhouse" -}} | ||||||
| enabled: true | ||||||
| type: system | ||||||
| imageSelector: wgetImage | ||||||
| imageSelector: ubuntuImage | ||||||
| securityContext: | ||||||
| runAsUser: 568 | ||||||
| runAsGroup: 568 | ||||||
|
|
@@ -280,7 +280,7 @@ args: | |||||
| {{- define "tc.v1.common.lib.deps.wait.solr" -}} | ||||||
| enabled: true | ||||||
| type: system | ||||||
| imageSelector: wgetImage | ||||||
| imageSelector: ubuntuImage | ||||||
|
||||||
| imageSelector: ubuntuImage | |
| imageSelector: wgetImage |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -144,30 +144,14 @@ | |
| "$ref": "file:///home/runner/work/truecharts/truecharts/charts/library/common/schemas/images/codeserverImage.json", | ||
| "description": "Configuration for `codeserverImage`." | ||
| }, | ||
| "alpineImage": { | ||
| "$ref": "file:///home/runner/work/truecharts/truecharts/charts/library/common/schemas/images/alpineImage.json", | ||
| "description": "Configuration for `alpineImage`." | ||
| }, | ||
| "ubuntuImage": { | ||
| "$ref": "file:///home/runner/work/truecharts/truecharts/charts/library/common/schemas/images/ubuntuImage.json", | ||
| "description": "Configuration for `ubuntuImage`." | ||
|
Comment on lines
144
to
149
|
||
| }, | ||
| "scratchImage": { | ||
| "$ref": "file:///home/runner/work/truecharts/truecharts/charts/library/common/schemas/images/scratchImage.json", | ||
| "description": "Configuration for `scratchImage`." | ||
| }, | ||
| "kubectlImage": { | ||
| "$ref": "file:///home/runner/work/truecharts/truecharts/charts/library/common/schemas/images/kubectlImage.json", | ||
| "description": "Configuration for `kubectlImage`." | ||
| }, | ||
| "wgetImage": { | ||
| "$ref": "file:///home/runner/work/truecharts/truecharts/charts/library/common/schemas/images/wgetImage.json", | ||
| "description": "Configuration for `wgetImage`." | ||
| }, | ||
| "yqImage": { | ||
| "$ref": "file:///home/runner/work/truecharts/truecharts/charts/library/common/schemas/images/yqImage.json", | ||
| "description": "Configuration for `yqImage`." | ||
| }, | ||
| "postgresClientImage": { | ||
| "$ref": "file:///home/runner/work/truecharts/truecharts/charts/library/common/schemas/images/postgresClientImage.json", | ||
| "description": "Configuration for `postgresClientImage`." | ||
|
|
@@ -176,10 +160,6 @@ | |
| "$ref": "file:///home/runner/work/truecharts/truecharts/charts/library/common/schemas/images/mariadbClientImage.json", | ||
| "description": "Configuration for `mariadbClientImage`." | ||
| }, | ||
| "redisClientImage": { | ||
| "$ref": "file:///home/runner/work/truecharts/truecharts/charts/library/common/schemas/images/redisClientImage.json", | ||
| "description": "Configuration for `redisClientImage`." | ||
| }, | ||
| "valkeyClientImage": { | ||
| "$ref": "file:///home/runner/work/truecharts/truecharts/charts/library/common/schemas/images/valkeyClientImage.json", | ||
| "description": "Configuration for `valkeyClientImage`." | ||
|
|
@@ -220,14 +200,6 @@ | |
| "$ref": "file:///home/runner/work/truecharts/truecharts/charts/library/common/schemas/images/postgresVectorchord16Image.json", | ||
| "description": "Configuration for `postgresVectorchord16Image`." | ||
| }, | ||
| "openvpnImage": { | ||
| "$ref": "file:///home/runner/work/truecharts/truecharts/charts/library/common/schemas/images/openvpnImage.json", | ||
| "description": "Configuration for `openvpnImage`." | ||
| }, | ||
| "wireguardImage": { | ||
| "$ref": "file:///home/runner/work/truecharts/truecharts/charts/library/common/schemas/images/wireguardImage.json", | ||
| "description": "Configuration for `wireguardImage`." | ||
| }, | ||
| "ingress": { | ||
| "$ref": "file:///home/runner/work/truecharts/truecharts/charts/library/common/schemas/ingress.json", | ||
| "description": "Create Ingress objects" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These wait containers previously used a dedicated
wgetImageselector; switching toubuntuImagecan couple the wait logic to whatever tooling happens to be present in the Ubuntu image. To avoid future drift (e.g., if the base image changes), consider documenting the required binaries for these wait containers (wget/curl/nc/etc.) or using an image selector whose name/contract explicitly guarantees those tools.