Skip to content

feat(common): Auto-generate complete-values-structure.yaml with objectname normalization #44955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crow-Control merged 8 commits into from
Feb 14, 2026
Merged

feat(common): Auto-generate complete-values-structure.yaml with objectname normalization #44955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ef7083e
Add generate_complete_values_structure.py script and integrate into w…
Copilot Feb 14, 2026
f016a74
Clean up generate_complete_values_structure.py - remove unused code
Copilot Feb 14, 2026
c09247b
Remove unused normalize_variable_keys function and dead code
Copilot Feb 14, 2026
0312388
Add ruamel.yaml support to preserve comments in complete-values-struc…
Copilot Feb 14, 2026
6953b7d
Restore check_complete_values_schema_coverage.py to workflow
Copilot Feb 14, 2026
befb513
Add normalization: use objectname for variable keys and placeholder v…
Copilot Feb 14, 2026
a09271a
Address code review: improve normalization efficiency and documentation
Copilot Feb 14, 2026
ecc8a3b
feat(common): Auto-generate complete-values-structure.yaml with objec…
Copilot Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/common-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,13 @@ jobs:
with:
python-version: "3.10"

- name: Install Python dependencies
run: pip install PyYAML ruamel.yaml

- name: Generate complete values structure
run: |
python3 charts/library/common/generate_complete_values_structure.py

Copy link

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow regenerates complete-values-structure.yaml but never verifies the committed file matches the generated output. That can allow the repository to drift (CI passes while the checked-in reference file is stale). Consider adding a git diff --exit-code check after generation (or explicitly deciding to not track the generated file in git).

Suggested change
- name: Verify complete values structure is up-to-date
run: |
git diff --exit-code -- charts/library/common/complete-values-structure.yaml

Copilot uses AI. Check for mistakes.
- name: Run schema validation
run: |
python3 charts/library/common/test_schema.py --max-failures 0 --output-file stable_schema_validation.log
Expand Down
Loading