Correctly log error message when pkg-install fails#348
Open
jburianek wants to merge 1 commit intotruenas:masterfrom
Open
Correctly log error message when pkg-install fails#348jburianek wants to merge 1 commit intotruenas:masterfrom
jburianek wants to merge 1 commit intotruenas:masterfrom
Conversation
(cherry picked from commit 9debf41)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: iocage#1270
If
pkg-installfails, we should ignore blank lines when attempting to send back a helpful error message to the user.This is because
e.messagecan look something like this:Which leads to a very unhelpful error message like this:
After this change the message is propagated back to the user: