-
Notifications
You must be signed in to change notification settings - Fork 2k
[Detector] rippling detector for phrase api tokens #4348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shahzadhaider1
merged 20 commits into
trufflesecurity:main
from
SyedAliHamad:OSS-264-rippling-detector-for-phrase-api-tokens
Aug 18, 2025
+440
−6
Merged
Changes from 5 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
decd6ca
add detector for phase OAuth Access Token
SyedAliHamad b6040c7
Merge branch 'main' into OSS-264-rippling-detector-for-phrase-api-tokens
SyedAliHamad a67029e
update test cases for phrase AccessTokens
SyedAliHamad 17b7475
update integration tests for phrase access token
SyedAliHamad 18c5383
Merge branch 'main' into OSS-264-rippling-detector-for-phrase-api-tokens
SyedAliHamad 629c183
resolve comments
SyedAliHamad 1006b26
Merge branch 'main' into OSS-264-rippling-detector-for-phrase-api-tokens
SyedAliHamad 0b29bf3
Merge branch 'main' into OSS-264-rippling-detector-for-phrase-api-tokens
SyedAliHamad e41cf25
Merge branch 'main' into OSS-264-rippling-detector-for-phrase-api-tokens
SyedAliHamad 5590309
add detector scanner in engine
SyedAliHamad 04e99b3
Merge branch 'main' into OSS-264-rippling-detector-for-phrase-api-tokens
SyedAliHamad 865987e
resolve comments
SyedAliHamad cb69a01
update test cases
SyedAliHamad 08ca03a
Merge branch 'main' into OSS-264-rippling-detector-for-phrase-api-tokens
amanfcp 24effb8
Merge branch 'main' into OSS-264-rippling-detector-for-phrase-api-tokens
SyedAliHamad b740ea6
Merge branch 'main' into OSS-264-rippling-detector-for-phrase-api-tokens
amanfcp fe757dc
Merge branch 'main' into OSS-264-rippling-detector-for-phrase-api-tokens
SyedAliHamad c599bf4
Merge branch 'main' into OSS-264-rippling-detector-for-phrase-api-tokens
kashifkhan0771 87814b4
Merge branch 'main' into OSS-264-rippling-detector-for-phrase-api-tokens
shahzadhaider1 6b92a56
addressed comment about the deduplication of tokens
shahzadhaider1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,113 @@ | ||
package phraseaccesstoken | ||
|
||
import ( | ||
"context" | ||
"fmt" | ||
"io" | ||
"net/http" | ||
|
||
regexp "github.com/wasilibs/go-re2" | ||
|
||
"github.com/trufflesecurity/trufflehog/v3/pkg/common" | ||
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors" | ||
"github.com/trufflesecurity/trufflehog/v3/pkg/pb/detectorspb" | ||
) | ||
|
||
type Scanner struct { | ||
client *http.Client | ||
} | ||
|
||
// Ensure the Scanner satisfies the interface at compile time. | ||
var _ detectors.Detector = (*Scanner)(nil) | ||
|
||
var ( | ||
defaultClient = common.SaneHttpClient() | ||
// Phrase access tokens are typically 64-character hexadecimal strings | ||
keyPat = regexp.MustCompile(detectors.PrefixRegex([]string{"phrase", "accessToken", "access_token"}) + `\b([a-z0-9]{64})\b`) | ||
) | ||
|
||
// Keywords are used for efficiently pre-filtering chunks. | ||
// Use identifiers in the secret preferably, or the provider name. | ||
func (s Scanner) Keywords() []string { | ||
return []string{"phrase"} | ||
} | ||
|
||
func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) { | ||
dataStr := string(data) | ||
|
||
uniqueMatches := make(map[string]struct{}) | ||
matches := keyPat.FindAllStringSubmatch(dataStr, -1) | ||
|
||
for _, match := range matches { | ||
// Ensure we have a proper capture group | ||
if len(match) < 2 { | ||
continue | ||
} | ||
|
||
token := match[1] | ||
if token == "" { | ||
continue | ||
} | ||
|
||
uniqueMatches[token] = struct{}{} | ||
} | ||
|
||
for token := range uniqueMatches { | ||
s1 := detectors.Result{ | ||
DetectorType: detectorspb.DetectorType_PhraseAccessToken, | ||
Raw: []byte(token), | ||
} | ||
|
||
if verify { | ||
client := s.client | ||
if client == nil { | ||
client = defaultClient | ||
} | ||
|
||
isVerified, extraData, verificationErr := verifyMatch(ctx, client, token) | ||
SyedAliHamad marked this conversation as resolved.
Show resolved
Hide resolved
|
||
s1.Verified = isVerified | ||
s1.ExtraData = extraData | ||
s1.SetVerificationError(verificationErr, token) | ||
} | ||
|
||
results = append(results, s1) | ||
} | ||
|
||
return results, nil | ||
} | ||
|
||
func verifyMatch(ctx context.Context, client *http.Client, token string) (bool, map[string]string, error) { | ||
req, err := http.NewRequestWithContext(ctx, http.MethodGet, "https://api.phrase.com/v2/projects", nil) | ||
SyedAliHamad marked this conversation as resolved.
Show resolved
Hide resolved
|
||
if err != nil { | ||
return false, nil, err | ||
} | ||
|
||
// Phrase uses Authorization header with "token" prefix | ||
req.Header.Add("Authorization", "token "+token) | ||
|
||
res, err := client.Do(req) | ||
if err != nil { | ||
return false, nil, err | ||
} | ||
defer func() { | ||
_, _ = io.Copy(io.Discard, res.Body) | ||
_ = res.Body.Close() | ||
}() | ||
|
||
switch res.StatusCode { | ||
case http.StatusOK: | ||
return true, nil, nil | ||
case http.StatusUnauthorized, http.StatusForbidden: | ||
return false, nil, nil | ||
default: | ||
return false, nil, fmt.Errorf("unexpected HTTP response status %d", res.StatusCode) | ||
} | ||
} | ||
|
||
func (s Scanner) Type() detectorspb.DetectorType { | ||
return detectorspb.DetectorType_PhraseAccessToken | ||
} | ||
|
||
func (s Scanner) Description() string { | ||
return "Phrase is a translation management platform for software projects. Phrase API keys can be used to access translation projects, locales, and manage translations." | ||
} |
177 changes: 177 additions & 0 deletions
177
pkg/detectors/phraseaccesstoken/phraseaccesstoken_integration_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,177 @@ | ||
//go:build detectors | ||
// +build detectors | ||
|
||
package phraseaccesstoken | ||
|
||
import ( | ||
"context" | ||
"fmt" | ||
"testing" | ||
"time" | ||
|
||
"github.com/google/go-cmp/cmp" | ||
"github.com/google/go-cmp/cmp/cmpopts" | ||
|
||
"github.com/trufflesecurity/trufflehog/v3/pkg/common" | ||
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors" | ||
"github.com/trufflesecurity/trufflehog/v3/pkg/pb/detectorspb" | ||
) | ||
|
||
func TestPhrase_FromChunk(t *testing.T) { | ||
ctx, cancel := context.WithTimeout(context.Background(), time.Second*5) | ||
defer cancel() | ||
testSecrets, err := common.GetSecret(ctx, "trufflehog-testing", "detectors6") | ||
if err != nil { | ||
t.Fatalf("could not get test secrets from GCP: %s", err) | ||
} | ||
secret := testSecrets.MustGetField("PHRASE_OAUTH_ACCESS_TOKEN") | ||
inactiveSecret := testSecrets.MustGetField("PHRASE_OAUTH_ACCESS_TOKEN_INACTIVE") | ||
|
||
type args struct { | ||
ctx context.Context | ||
data []byte | ||
verify bool | ||
} | ||
tests := []struct { | ||
name string | ||
s Scanner | ||
args args | ||
want []detectors.Result | ||
wantErr bool | ||
wantVerificationErr bool | ||
}{ | ||
{ | ||
name: "found, verified", | ||
s: Scanner{}, | ||
args: args{ | ||
ctx: context.Background(), | ||
data: []byte(fmt.Sprintf("You can find a phrase secret %s within", secret)), | ||
verify: true, | ||
}, | ||
want: []detectors.Result{ | ||
{ | ||
DetectorType: detectorspb.DetectorType_PhraseAccessToken, | ||
Verified: true, | ||
Raw: []byte(secret), | ||
}, | ||
}, | ||
wantErr: false, | ||
wantVerificationErr: false, | ||
}, | ||
{ | ||
name: "found, unverified", | ||
s: Scanner{}, | ||
args: args{ | ||
ctx: context.Background(), | ||
data: []byte(fmt.Sprintf("You can find a phrase secret %s within but not valid", inactiveSecret)), | ||
verify: true, | ||
}, | ||
want: []detectors.Result{ | ||
{ | ||
DetectorType: detectorspb.DetectorType_PhraseAccessToken, | ||
Verified: false, | ||
Raw: []byte(inactiveSecret), | ||
}, | ||
}, | ||
wantErr: false, | ||
wantVerificationErr: false, | ||
}, | ||
{ | ||
name: "not found", | ||
s: Scanner{}, | ||
args: args{ | ||
ctx: context.Background(), | ||
data: []byte("You cannot find the secret within"), | ||
verify: true, | ||
}, | ||
want: nil, | ||
wantErr: false, | ||
wantVerificationErr: false, | ||
}, | ||
{ | ||
name: "found, would be verified if not for timeout", | ||
s: Scanner{client: common.SaneHttpClientTimeOut(1 * time.Microsecond)}, | ||
args: args{ | ||
ctx: context.Background(), | ||
data: []byte(fmt.Sprintf("You can find a phrase secret %s within", secret)), | ||
verify: true, | ||
}, | ||
want: []detectors.Result{ | ||
{ | ||
DetectorType: detectorspb.DetectorType_PhraseAccessToken, | ||
Verified: false, | ||
Raw: []byte(secret), | ||
}, | ||
}, | ||
wantErr: false, | ||
wantVerificationErr: true, | ||
}, | ||
{ | ||
name: "found, verified but unexpected api surface", | ||
s: Scanner{client: common.ConstantResponseHttpClient(404, "")}, | ||
args: args{ | ||
ctx: context.Background(), | ||
data: []byte(fmt.Sprintf("You can find a phrase secret %s within", secret)), | ||
verify: true, | ||
}, | ||
want: []detectors.Result{ | ||
{ | ||
DetectorType: detectorspb.DetectorType_PhraseAccessToken, | ||
Verified: false, | ||
Raw: []byte(secret), | ||
}, | ||
}, | ||
wantErr: false, | ||
wantVerificationErr: true, | ||
}, | ||
} | ||
|
||
for _, tt := range tests { | ||
t.Run(tt.name, func(t *testing.T) { | ||
got, err := tt.s.FromData(tt.args.ctx, tt.args.verify, tt.args.data) | ||
if (err != nil) != tt.wantErr { | ||
t.Errorf("Phrase.FromData() error = %v, wantErr %v", err, tt.wantErr) | ||
return | ||
} | ||
|
||
// Validate that we got results when expected | ||
if len(got) != len(tt.want) { | ||
t.Errorf("Phrase.FromData() got %d results, want %d", len(got), len(tt.want)) | ||
return | ||
} | ||
|
||
// Check individual results | ||
for i := range got { | ||
if len(got[i].Raw) == 0 { | ||
t.Fatalf("no raw secret present: \n %+v", got[i]) | ||
} | ||
if (got[i].VerificationError() != nil) != tt.wantVerificationErr { | ||
t.Fatalf("wantVerificationError = %v, verification error = %v", tt.wantVerificationErr, got[i].VerificationError()) | ||
} | ||
} | ||
|
||
// Use IgnoreUnexported to handle the unexported primarySecret field | ||
// Also ignore verificationError as it's handled separately above | ||
ignoreOpts := cmpopts.IgnoreUnexported(detectors.Result{}) | ||
if diff := cmp.Diff(tt.want, got, ignoreOpts); diff != "" { | ||
t.Errorf("Phrase.FromData() %s diff: (-want +got)\n%s", tt.name, diff) | ||
} | ||
}) | ||
} | ||
} | ||
|
||
func BenchmarkFromData(benchmark *testing.B) { | ||
ctx := context.Background() | ||
s := Scanner{} | ||
for name, data := range detectors.MustGetBenchmarkData() { | ||
benchmark.Run(name, func(b *testing.B) { | ||
b.ResetTimer() | ||
for n := 0; n < b.N; n++ { | ||
_, err := s.FromData(ctx, false, data) | ||
if err != nil { | ||
b.Fatal(err) | ||
} | ||
} | ||
}) | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.