Refactored caflou detector #4372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kashifkhan0771 this is already under review in #4315 Please do give your review as per your findings there |
I reviewed that PR. It updates the verification logic. |
shahzadhaider1
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR refactors the Caflou token detector.
The existing regex pattern was too broad and for somehow had
a-bonly for small letters 😅, so this update narrows it to reduce false positives. I also observed that all Caflou tokens share a fixed prefix, which has now been incorporated into the pattern for improved accuracy.Checklist:
make test-community)?make lintthis requires golangci-lint)?