-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[INS-241] Datadogapikey detector #4627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MuneebUllahKhan222
wants to merge
20
commits into
trufflesecurity:main
Choose a base branch
from
MuneebUllahKhan222:datadogapikey-detector
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[INS-241] Datadogapikey detector #4627
MuneebUllahKhan222
wants to merge
20
commits into
trufflesecurity:main
from
MuneebUllahKhan222:datadogapikey-detector
+1,517
−799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashifkhan0771
requested changes
Jan 2, 2026
kashifkhan0771
requested changes
Jan 5, 2026
amanfcp
approved these changes
Jan 9, 2026
nabeelalam
reviewed
Jan 12, 2026
nabeelalam
reviewed
Jan 12, 2026
Removed commented-out code for appKey and endpoint.
shahzadhaider1
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Previously, the
datadogtokendetector was responsible for verifying both API keys and Application keys for Datadog. This caused an issue where an invalid Application key would incorrectly mark a valid API key as unverified, leading to false positives.To resolve this, we have introduced a new detector:
datadogapikey. This detector is focused solely on validating Datadog API keys, ensuring that API key verification is isolated and accurate, independent of the App key status.Checklist:
make test-community)?make lintthis requires golangci-lint)?