Skip to content

Massively improve search engine capabilities #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jplitza wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Massively improve search engine capabilities #33

jplitza wants to merge 5 commits into from

Conversation

@jplitza
Copy link

@jplitza jplitza commented Nov 1, 2019

  • Fixes query string building (handles & correctly)
  • Allow to pass additional params
  • Also convert forcedisplay values to field IDs

Example query that is now possible:

glpi.search_engine('computer', { "criteria": [{'field': 'name', 'value': 'noc'}], 'range': '0-0', 'uid_cols': True, 'forcedisplay': ['serial']})

Jan-Philipp Litza added 4 commits November 1, 2019 16:38
search_engine: Make requests assemble the GET params
5aac748 
The manual approach was vulnerable to injection of & and thus additional
parameters
search_engine: Allow to pass other parameters
1662dac 
We simply pass through everything that isn't the "criteria" parameter.

This allows for specifying the range an other parameters of the search
search_engine: Also map forcedisplay values to field IDs
93b7e94
search_engine: Support nested filter groups
8a5ce52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jplitza