options for disabling knapsack collection #927
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatheson
requested review from
TylerJang27,
acatxnamedvirtue,
cmillar-trunk,
gnalh,
max-trunk and
mb1206
as code owners
|
Merging to
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #927 +/- ##
==========================================
+ Coverage 72.85% 73.82% +0.97%
==========================================
Files 72 72
Lines 16465 16461 -4
==========================================
+ Hits 11995 12152 +157
+ Misses 4470 4309 -161 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 similar comment
gnalh
approved these changes
Dec 18, 2025
TylerJang27
approved these changes
Dec 18, 2025
|
|
||
| # trunk-ignore(rubocop/Metrics/CyclomaticComplexity,rubocop/Metrics/AbcSize,rubocop/Metrics/MethodLength) | ||
| def add_test_case(example) | ||
| return if ENV['KNAPSACK_PRO_TEST_EXAMPLE_DETECTOR'] == 'true' |
Collaborator
There was a problem hiding this comment.
Undocumented. I'm assuming you found this by hand? If this works, let's add a canary for it
acatxnamedvirtue
approved these changes
Dec 18, 2025
mb1206
approved these changes
Dec 18, 2025
gnalh
reviewed
Dec 18, 2025
|
|
||
| # trunk-ignore(rubocop/Metrics/CyclomaticComplexity,rubocop/Metrics/AbcSize,rubocop/Metrics/MethodLength) | ||
| def add_test_case(example) | ||
| return if ENV['KNAPSACK_PRO_TEST_EXAMPLE_DETECTOR'] == 'true' |
Contributor
There was a problem hiding this comment.
Let's also add inline comments here explaining why we need this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.