Skip to content

Conversation

@mmatheson
Copy link
Member

knapsack_pro:rspec_test_example_detector instantiates all tests in a file to determine how to split by test examples (reference). This step is done before actually running the tests. When that happens, the RSpec reporter reports all test examples as passing, despite the fact that they're not actually run.

This change checks if the command line contains "knapsack_pro:rspec_test_example_detector", and if so, disables test collection and uploading.

@trunk-io
Copy link

trunk-io bot commented Dec 19, 2025

😎 Merged successfully - details.

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.82%. Comparing base (ff2d433) to head (4da9d8c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
+ Coverage   73.58%   73.82%   +0.23%     
==========================================
  Files          72       72              
  Lines       16461    16461              
==========================================
+ Hits        12113    12152      +39     
+ Misses       4348     4309      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trunk-staging-io
Copy link

trunk-staging-io bot commented Dec 19, 2025

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Copy link
Contributor

@gnalh gnalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that we do a quick follow up to add smoke tests / canary tests for this flow. I don't want us to be surprised if / when this breaks.

@trunk-io trunk-io bot merged commit 7c1b0da into main Dec 19, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants