Skip to content

Pin rb_sys version when building for smoketests & release #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trunk-io merged 11 commits into from
Jan 6, 2026
Merged

Pin rb_sys version when building for smoketests & release #970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f8f8100
try fix smoke test
max-trunk Jan 6, 2026
7106b3e
just cp lock file so cross-gem can see it
max-trunk Jan 6, 2026
8580c21
try lower version
max-trunk Jan 6, 2026
65ca6e9
had i really not tried this yet
max-trunk Jan 6, 2026
4dab36e
or this, rather
max-trunk Jan 6, 2026
1213077
pin to patch
max-trunk Jan 6, 2026
8037e83
try this
max-trunk Jan 6, 2026
d15ab4f
simplify
max-trunk Jan 6, 2026
fdeaa79
update rb_sys
max-trunk Jan 6, 2026
3cded64
cleanup
max-trunk Jan 6, 2026
c09fcab
pin rake compiler version
max-trunk Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/release_ruby_gem.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,12 @@ jobs:
version: ${{ github.event.inputs.release_tag || inputs.release_tag }}
file: rspec-trunk-flaky-tests/rspec_trunk_flaky_tests.gemspec

# this is necessary because the cross-gem action doesn't support reading the Gemfile.lock from the subdirectory
# leading to a mismatch in the rb_sys version
Copy link
Collaborator

@cmillar-trunk cmillar-trunk Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent comment explaining the arcana here, thank you.

- name: Copy Gemfile.lock to root
run: cp rspec-trunk-flaky-tests/Gemfile.lock ./Gemfile.lock
shell: bash

- uses: oxidize-rb/actions/cross-gem@v1
with:
platform: ${{ matrix.platform }}
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/smoke_test_main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ on:
types:
- staging-release
- production-release

jobs:
build_cli:
name: Smoke test ${{ matrix.platform.name }} cli from release
Expand Down Expand Up @@ -183,6 +184,12 @@ jobs:
version: 0.0.0-${{ steps.get-sha.outputs.sha }}
file: rspec-trunk-flaky-tests/rspec_trunk_flaky_tests.gemspec

# this is necessary because the cross-gem action doesn't support reading the Gemfile.lock from the subdirectory
# leading to a mismatch in the rb_sys version
- name: Copy Gemfile.lock to root
run: cp rspec-trunk-flaky-tests/Gemfile.lock ./Gemfile.lock
shell: bash

- name: Build cross-compiled gem
uses: oxidize-rb/actions/cross-gem@v1
with:
Expand Down
Loading