Reintroduce serde deps #976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We killed a few serde dependencies that seemed to be unneeded, but the cli secretly does need them, which was causing cli releases to fail.
cmillar-trunk
requested review from
TylerJang27,
acatxnamedvirtue,
max-trunk and
mb1206
as code owners
|
😎 Merged successfully - details. |
TylerJang27
approved these changes
Jan 8, 2026
max-trunk
approved these changes
Jan 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #976 +/- ##
==========================================
+ Coverage 80.80% 81.08% +0.27%
==========================================
Files 66 66
Lines 14101 14101
==========================================
+ Hits 11395 11434 +39
+ Misses 2706 2667 -39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We killed a few serde dependencies that seemed to be unneeded, but the cli secretly does need them, which was causing cli releases to fail.