Ignore *.dockerignore files as they do not conform to the Dockerfile spec#943
Merged
TylerJang27 merged 1 commit intotrunk-io:mainfrom Dec 30, 2024
Merged
Ignore *.dockerignore files as they do not conform to the Dockerfile spec#943TylerJang27 merged 1 commit intotrunk-io:mainfrom
TylerJang27 merged 1 commit intotrunk-io:mainfrom
Conversation
⏱️ 43m total CI duration on this PR
|
TylerJang27
approved these changes
Dec 30, 2024
Collaborator
TylerJang27
left a comment
TylerJang27
left a comment
There was a problem hiding this comment.
Good catch! Thanks again!
TylerJang27
added a commit
that referenced
this pull request
Apr 2, 2025
Reverts #943 and also adds an ignore to handle the original request Fixes the error log `Error parsing '(?i)(?:^|/)Dockerfile\.(?!.*\.dockerignore$).+$': invalid perl operator: (?!`, since re2 doesn't support negative matches. Tested that the log is no longer there and `trunk check query` produces the correct LQRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker supports ignore files to keep build contexts clean.
The current configuration ignores the generic
.dockerignoreas expected, but attempts to lint Dockerfile-specific configurations such asDockerfile.dockerignore,test.Dockerfile.dockerignoreandDockerfile.build.dockerignore.This PR aims to resolve this bug.