Skip to content

Commit 59d22a3

Browse files
authored
Merge pull request #75 from trurl-master/claude/issue-74-20250818-1038
fix: move puppeteer to devDependencies
2 parents 5e8d618 + 9a82ddd commit 59d22a3

File tree

4 files changed

+19
-16
lines changed

4 files changed

+19
-16
lines changed

.github/workflows/claude-code-review.yml

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@ jobs:
1717
# github.event.pull_request.user.login == 'external-contributor' ||
1818
# github.event.pull_request.user.login == 'new-developer' ||
1919
# github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR'
20-
20+
2121
runs-on: ubuntu-latest
2222
permissions:
2323
contents: read
2424
pull-requests: read
2525
issues: read
2626
id-token: write
27-
27+
2828
steps:
2929
- name: Checkout repository
3030
uses: actions/checkout@v4
@@ -39,40 +39,43 @@ jobs:
3939

4040
# Optional: Specify model (defaults to Claude Sonnet 4, uncomment for Claude Opus 4)
4141
# model: "claude-opus-4-20250514"
42-
42+
43+
# Allow any bot to trigger the review
44+
allowed_bots: '*'
45+
4346
# Direct prompt for automated review (no @claude mention needed)
4447
direct_prompt: |
4548
Please review this pull request and provide feedback on:
4649
- Code quality and best practices
50+
- Accessibility
4751
- Potential bugs or issues
4852
- Performance considerations
4953
- Security concerns
5054
- Test coverage
51-
52-
Be constructive and helpful in your feedback.
55+
56+
Be concise and constructive in your feedback.
5357
5458
# Optional: Use sticky comments to make Claude reuse the same comment on subsequent pushes to the same PR
5559
# use_sticky_comment: true
56-
60+
5761
# Optional: Customize review based on file types
5862
# direct_prompt: |
5963
# Review this PR focusing on:
6064
# - For TypeScript files: Type safety and proper interface usage
6165
# - For API endpoints: Security, input validation, and error handling
6266
# - For React components: Performance, accessibility, and best practices
6367
# - For tests: Coverage, edge cases, and test quality
64-
68+
6569
# Optional: Different prompts for different authors
6670
# direct_prompt: |
67-
# ${{ github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR' &&
71+
# ${{ github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR' &&
6872
# 'Welcome! Please review this PR from a first-time contributor. Be encouraging and provide detailed explanations for any suggestions.' ||
6973
# 'Please provide a thorough code review focusing on our coding standards and best practices.' }}
70-
74+
7175
# Optional: Add specific tools for running tests or linting
7276
# allowed_tools: "Bash(npm run test),Bash(npm run lint),Bash(npm run typecheck)"
73-
77+
7478
# Optional: Skip review for certain conditions
7579
# if: |
7680
# !contains(github.event.pull_request.title, '[skip-review]') &&
7781
# !contains(github.event.pull_request.title, '[WIP]')
78-

jest.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/** @type {import('ts-jest/dist/types').InitialOptionsTsJest} */
2-
module.exports = {
2+
export default {
33
preset: 'ts-jest',
44
testEnvironment: 'jsdom',
55
setupFilesAfterEnv: ['<rootDir>/jest-setup.ts'],

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "jsdom-testing-mocks",
3-
"version": "1.15.2",
3+
"version": "1.16.0",
44
"author": "Ivan Galiatin",
55
"license": "MIT",
66
"description": "A set of tools for emulating browser behavior in jsdom environment",
@@ -83,11 +83,11 @@
8383
},
8484
"dependencies": {
8585
"bezier-easing": "^2.1.0",
86-
"css-mediaquery": "^0.1.2",
87-
"puppeteer": "^24.15.0"
86+
"css-mediaquery": "^0.1.2"
8887
},
8988
"devDependencies": {
9089
"@playwright/test": "^1.54.1",
90+
"puppeteer": "^24.15.0",
9191
"@swc/core": "^1.3.82",
9292
"@swc/jest": "^0.2.29",
9393
"@types/css-mediaquery": "^0.1.1",

swcjest.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
module.exports = {
1+
export default {
22
testEnvironment: 'jsdom',
33
transform: {
44
'^.+\\.(t|j)sx?$': '@swc/jest',

0 commit comments

Comments
 (0)