Fix private method access issue in AnimationEffect for transpiled environments #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62
Problem
When using
mockAnimationsApi(), users encounter aTypeError: Cannot access private methoderror. The error occurs ingetComputedTiming()which calls#getNormalizedDuration()from theMockedAnimationEffectclass.Root Cause
The issue stems from private method inheritance limitations in certain JavaScript environments:
MockedKeyframeEffectextendsMockedAnimationEffectgetComputedTiming()in the parent class calls the private method#getNormalizedDuration()Solution
Convert the private method
#getNormalizedDuration()to a protected method_getNormalizedDuration():Benefits
Changes
src/mocks/web-animations-api/AnimationEffect.ts: Convert private method to protectedpackage.json: Bump version to 1.15.1Testing
This fix ensures compatibility across different JavaScript transpilation environments while maintaining the intended class hierarchy and functionality.