Add support for disabling block count check on mount and shrinking filesystems #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
shrink
branch
from
2ca392b to
1d35890
Compare
Member
robin-nitrokey
left a comment
robin-nitrokey
left a comment
There was a problem hiding this comment.
It would be good to have test cases for a failed mount if the flag is not set, a successful mount if the flag is set and the different resize operations (successful grow, successful shrink, failed shrink for a full FS).
robin-nitrokey
approved these changes
May 12, 2025
| // } | ||
|
|
||
| #[test] | ||
| fn shrinking() { |
Member
There was a problem hiding this comment.
Maybe I’m a bit paranoid, but what about creating a file and making sure that it can still be read correctly after growing / shrinking?
Contributor
Author
There was a problem hiding this comment.
Done.
The C code already has a lot of such tests.
robin-nitrokey
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See trussed-dev/littlefs2-sys#27