Fix offset calculation overflowing on large storage devices#124
Merged
robin-nitrokey merged 1 commit intotrussed-dev:mainfrom Mar 4, 2026
Conversation
Member
|
Good catch, thank you! Let’s merge this as-is and implement the error handling separately, see #125. |
robin-nitrokey
force-pushed
the
fix/offset-calc-overflow-on-large-sd-cards
branch
from
83b6db1 to
f31f4dc
Compare
robin-nitrokey
added
skip-publish-check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes offset calculation overflowing on large storage devices.
The overflow can happen on the
lfs_config_readandlfs_config_progC callback functions.The overflow does not happen on other two low level C callback functions as it already uses usize.
I decided to use usize instead of u64 as
Storagedriver accepts a usize. So the overflow can still happen on 32 bit systems for large storage devices.Please let me know if you want to handle the overflow more gracefully with error codes as well, I would be more than happy to update it.