core: Make Path and PathBuf more const-friendly and release v0.1.1#89
Merged
robin-nitrokey merged 3 commits intomainfrom Jan 17, 2025
Merged
core: Make Path and PathBuf more const-friendly and release v0.1.1#89robin-nitrokey merged 3 commits intomainfrom
robin-nitrokey merged 3 commits intomainfrom
Conversation
This patch makes Path and PathBuf more const-friendly by adding some new const methods and marking existing methods as const.
We already have the path macro and PathBuf::from_path. Having a separate path_buf macro makes the code more readable and ensures compile-time evaluation.
robin-nitrokey
force-pushed
the
const-pathbuf
branch
from
9630c34 to
c31e789
Compare
sosthene-nitrokey
approved these changes
Jan 17, 2025
Comment on lines
+98
to
+104
| const _PATH: $crate::PathBuf = | ||
| match $crate::Path::from_str_with_nul(::core::concat!($path, "\0")) { | ||
| Ok(path) => $crate::PathBuf::from_path(path), | ||
| Err(_) => panic!("invalid littlefs2 path"), | ||
| }; | ||
| _PATH | ||
| }}; |
Contributor
There was a problem hiding this comment.
Is it purposefully not using an inline const block?
Member
Author
There was a problem hiding this comment.
Yes, I think the workaround is simple enough to avoid bumping the MSRV just for inline const blocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch makes some
PathandPathBufmethods const, adds newconsthelper functions and apath_bufmacro similar to the existingpathand releases littlefs2-core v0.1.1 with these changes.