Remove trait and result arguments from macros#94
Merged
robin-nitrokey merged 1 commit intomainfrom Feb 28, 2025
Merged
Conversation
The const_ram_storage! and ram_storage! macros used to have trait and result arguments to set the storage trait to implement and the result type to use. As this defaulted to relative paths, it made the result of the macro dependent on the context and could cause confusion. At the same time, there is no real use case for substituting these types. This patch removes the arguments for good and just uses $crate::driver::Storage and $crate::io::Result instead.
Merged
sosthene-nitrokey
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
const_ram_storage!andram_storage!macros used to have trait and result arguments to set the storage trait to implement and the result type to use. As this defaulted to relative paths, it made the result of the macro dependent on the context and could cause confusion. At the same time, there is no real use case for substituting these types.This patch removes the arguments for good and just uses
$crate::driver::Storageand$crate::io::Resultinstead.As we prepare a breaking release, I’d like to pull in this change that fixes a very annoying macro hygiene issue.