Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/components/forms/FileInput/FilePreview.test.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react'
import React, { StrictMode } from 'react'
import { fireEvent, render, waitFor } from '@testing-library/react'

import { FilePreview } from './FilePreview'
Expand Down Expand Up @@ -27,6 +27,16 @@ describe('FilePreview component', () => {
)
})

it('renders without errors when loaded multiple times (simulating react dev mode)', () => {
const { getByTestId } = render(
<StrictMode>
<FilePreview imageId="" file={TEST_TEXT_FILE} />
</StrictMode>
)

expect(getByTestId('file-input-preview')).toBeInTheDocument()
})

it('renders a preview image', async () => {
const { getByTestId } = await waitFor(() =>
render(<FilePreview {...testProps} />)
Expand Down
13 changes: 9 additions & 4 deletions src/components/forms/FileInput/FilePreview.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,23 @@ export const FilePreview = ({
const [isLoading, setIsLoading] = useState(true)
const [previewSrc, setPreviewSrc] = useState(SPACER_GIF)
const [showGenericPreview, setShowGenericPreview] = useState(false)
const firstRenderRef = useRef(false)

useEffect(() => {
if (firstRenderRef.current) {
// already run, do nothing
return
}
// only run once
firstRenderRef.current = true

fileReaderRef.current.onloadend = (): void => {
setIsLoading(false)
setPreviewSrc(fileReaderRef.current.result as string)
fileReaderRef.current.onloadend = null // is only run once
}

fileReaderRef.current.readAsDataURL(file)

return (): void => {
fileReaderRef.current.onloadend = null
}
}, [])

const { name } = file
Expand Down