Skip to content

feat: upgrade to USWDS 3.8.2#3263

Merged
brandonlenz merged 64 commits intotrussworks:mainfrom
mdmower-csnw:an-mdm-3.8.1
Nov 10, 2025
Merged

feat: upgrade to USWDS 3.8.2#3263
brandonlenz merged 64 commits intotrussworks:mainfrom
mdmower-csnw:an-mdm-3.8.1

Conversation

@mdmower-csnw
Copy link
Contributor

@mdmower-csnw mdmower-csnw commented Sep 20, 2025

This is a continuation of #2848 by @werdnanoslen since it doesn't look like additional movement is expected there.

Summary

These are the features released by USWDS in 3.8.0, 3.8.1, and 3.8.2:

  • Added styles for indeterminate checkboxes and radios
  • Added the ability to customize which headings will be pulled into the in-page navigation link list
    • Also changed class name and selection criteria for bolded heading
  • Added a sticky header variant to the table component
  • Updated sidenav example in documentation per new theme setting
  • Made tooltip content hoverable
  • Made tooltip dismissible with escape key
  • Added textarea validation storybook entry
  • Changed button centering from text-center to flex-justify-center since display for buttons changed from inline-block to inline-flex in USWDS - Button: Add basic support for usa-icon in buttons uswds/uswds#5398.
  • Removed tooltip opacity override that was fixed by USWDS: USWDS - Tooltip: Add opacity:0 to initial state uswds/uswds#5475
  • Changed button-based pagination to use <button> instead of <Button unstyled> to avoid style conflicts between usa-button--unstyled and usa-pagination__button classes (notably, hover styles). Apply minimal utility classes to align styles with link-based pagination.

No action needed to support $theme-table-background-color. It has been verified working by temporarily setting $theme-table-background-color: 'primary-vivid' in src/styles/_uswds-theme.scss and then rebuilding USWDS (yarn build:uswds) followed by running the storybook (yarn storybook).

Related Issues or PRs

Supersedes #2848 and #2962.

How To Test

Confirm things work the same as described in USWDS release notes: 3.8.0, 3.8.1, and 3.8.2.

Happo differences

  • Components/Search/SearchButton/Small search: Alignment of the icon in mobile layout is fixed by USWDS styles.
  • Components/Search/SearchButton/* and Components/Search/Search/*: All of these very slight button height differences are the result of display changing from inline-block to inline-flex in USWDS - Button: Add basic support for usa-icon in buttons uswds/uswds#5398. Opting to allow changes.

Otherwise, headers need to be in a certain DOM context to avoid a11y issues, and this is how USWDS does it
also matches uswds implementation, fixed tests
@mdmower-csnw
Copy link
Contributor Author

mdmower-csnw commented Sep 20, 2025

@jpandersen87 @brandonlenz (and cc: @werdnanoslen just in case you are still active in the project) - Would you be willing to review this changeset? I think it'd be best to increment USWDS one or two minor versions at a time, rather than trying to jump to the latest revision. Plus, @werdnanoslen had this 3.8 update largely done and it would be nice to respect his contribution.

EDIT: FYI, I've started work on 3.9 (#3264), 3.10 (#3265), and 3.11+3.12+3.13 (#3266).

@mdmower-csnw
Copy link
Contributor Author

@crwallace - I just noticed you are listed as the active maintainer for this project in the readme. Are you able to help with reviews? Thanks!

I've also started work on 3.9 (#3264), 3.10 (#3265), and 3.11+3.12+3.13 (#3266).

Copy link
Contributor

@brandonlenz brandonlenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should resolve the CI failures and let us move forward with merging @mdmower-csnw.

Would love to coordinate getting these updates out with you this week if you're available for that

@brandonlenz brandonlenz self-requested a review November 10, 2025 19:06
Copy link
Contributor

@brandonlenz brandonlenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

I noticed one change needed for the sticky header table story, and one potential bug/inconsistency with the Tooltip Escape key functionality

- Make sticky header sticky in table stories
- Make tooltip escape work without requiring trigger to be focussed
@brandonlenz
Copy link
Contributor

brandonlenz commented Nov 10, 2025

Thanks @mdmower-csnw, this is a huge help.

I'm going to cut a quick release tomorrow of all the changes on main leading up to this, then I want to release this as a part of its own (likely 10.2.0) release, just because its been a little while since we've updated the USWDS dependency and I want to give consumers another version to easily roll back to if needed.

@brandonlenz brandonlenz enabled auto-merge (squash) November 10, 2025 22:15
@brandonlenz brandonlenz merged commit 443a077 into trussworks:main Nov 10, 2025
8 checks passed
@brandonlenz
Copy link
Contributor

@all-contributors please add @mdmower-csnw for bug, code, maintenance

@allcontributors
Copy link
Contributor

@brandonlenz

I've put up a pull request to add @mdmower-csnw! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants