feat: upgrade to USWDS 3.8.2#3263
Conversation
Otherwise, headers need to be in a certain DOM context to avoid a11y issues, and this is how USWDS does it
also matches uswds implementation, fixed tests
…uswds into an-storybooka11y-fixes
|
@jpandersen87 @brandonlenz (and cc: @werdnanoslen just in case you are still active in the project) - Would you be willing to review this changeset? I think it'd be best to increment USWDS one or two minor versions at a time, rather than trying to jump to the latest revision. Plus, @werdnanoslen had this 3.8 update largely done and it would be nice to respect his contribution. EDIT: FYI, I've started work on 3.9 (#3264), 3.10 (#3265), and 3.11+3.12+3.13 (#3266). |
|
@crwallace - I just noticed you are listed as the active maintainer for this project in the readme. Are you able to help with reviews? Thanks! I've also started work on 3.9 (#3264), 3.10 (#3265), and 3.11+3.12+3.13 (#3266). |
brandonlenz
left a comment
There was a problem hiding this comment.
This should resolve the CI failures and let us move forward with merging @mdmower-csnw.
Would love to coordinate getting these updates out with you this week if you're available for that
brandonlenz
left a comment
There was a problem hiding this comment.
This looks great.
I noticed one change needed for the sticky header table story, and one potential bug/inconsistency with the Tooltip Escape key functionality
- Make sticky header sticky in table stories - Make tooltip escape work without requiring trigger to be focussed
|
Thanks @mdmower-csnw, this is a huge help. I'm going to cut a quick release tomorrow of all the changes on main leading up to this, then I want to release this as a part of its own (likely 10.2.0) release, just because its been a little while since we've updated the USWDS dependency and I want to give consumers another version to easily roll back to if needed. |
|
@all-contributors please add @mdmower-csnw for bug, code, maintenance |
|
I've put up a pull request to add @mdmower-csnw! 🎉 |
This is a continuation of #2848 by @werdnanoslen since it doesn't look like additional movement is expected there.
Summary
These are the features released by USWDS in 3.8.0, 3.8.1, and 3.8.2:
text-centertoflex-justify-centersincedisplayfor buttons changed frominline-blocktoinline-flexin USWDS - Button: Add basic support for usa-icon in buttons uswds/uswds#5398.<button>instead of<Button unstyled>to avoid style conflicts betweenusa-button--unstyledandusa-pagination__buttonclasses (notably, hover styles). Apply minimal utility classes to align styles with link-based pagination.No action needed to support
$theme-table-background-color. It has been verified working by temporarily setting$theme-table-background-color: 'primary-vivid'insrc/styles/_uswds-theme.scssand then rebuilding USWDS (yarn build:uswds) followed by running the storybook (yarn storybook).Related Issues or PRs
Supersedes #2848 and #2962.
How To Test
Confirm things work the same as described in USWDS release notes: 3.8.0, 3.8.1, and 3.8.2.
Happo differences
displaychanging frominline-blocktoinline-flexin USWDS - Button: Add basic support for usa-icon in buttons uswds/uswds#5398. Opting to allow changes.