Skip to content

Conversation

@iroykaufman
Copy link

See README.md for details.

FROM quay.io/rkaufman/kbs-tpm-snp:latest as kbc
FROM quay.io/openshift-release-dev/ocp-v4.0-art-dev:419.96.202505021444-0-coreos

COPY usr /usr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can copy directory by directory based on the argument/label. We should really maintain a single Containerfile

@alicefr
Copy link
Contributor

alicefr commented Oct 7, 2025

@iroykaufman can you please use the clevis pin instead of the old script running the attestation agent? It should also be easier for you. We should align to the latest way to perform attestation

@iroykaufman iroykaufman force-pushed the trustee-on-GCP branch 2 times, most recently from 0c280f3 to e2e5133 Compare October 23, 2025 08:48
coreos/justfile Outdated
label := if os == "scos" { scos_label } else { fcos_label }
archive := os + ".ociarchive"
platform := "qemu"
kbc_image := "quay.io/afrosi_rh/kbs-client-image:latest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version support TPM as an additional device?

Copy link
Contributor

@alicefr alicefr Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is built from the latest guest component, but you need to register the trusted AK in trustee.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked again in the upstream and it's look like the TPM can only be primary device. This is where I look https://github.com/confidential-containers/guest-components/blob/main/attestation-agent/attester/src/lib.rs .
I created this PR#1093 to add this option

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I might have misunderstood the previous comment. Isn't the tpm the attester used on GCP?

Copy link
Author

@iroykaufman iroykaufman Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only, also SEV-SNP is use for attestation. I add the option for a vm with TPM and another TEE to set the TPM as an additional device for attestation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see. We didn't detect this because the local dev environment isn't a real CVM. Would you mind to fork the guest component in our org and add your patch there? In this way, we know which version is working and build the images out of it. Once, the PR is merged we can delete the repository.
We should try to have common images where we do our testing otherwise, it becomes very messy
/cc @Jakob-Naucke

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have permissions to add a fork.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added you, you should have an invitation

@iroykaufman iroykaufman force-pushed the trustee-on-GCP branch 3 times, most recently from c84a30a to ca6e9e4 Compare November 16, 2025 14:06
Roy Kaufman added 5 commits November 23, 2025 12:51
Also, use the shared Containerfile for the custom image.

Signed-off-by: Roy Kaufman <[email protected]>
using AK registration

Signed-off-by: Roy Kaufman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants