-
Notifications
You must be signed in to change notification settings - Fork 8
Add design for the boostrap phase #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alicefr The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
patrickdillon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we identify what details (at a high-level) the user will need to pass to the installer? Perhaps just the address of the external attestation server and key?
|
|
||
| ## Migration of the operator in cluster | ||
|
|
||
| Once the cluster has finished the boostrap phase, the Trusted Execution Cluster operator will be deployed in the boostrapped cluster and can start to attest the new upcoming node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the external cluster attesting only the control plane or also the compute nodes specified at install time?
In either case, how do we pivot after installation from using the external cluster to using the in-cluster operator? Specifically, we need to update the ignition stubs to point to the operator rather than the external cluster.
I can help iron out these details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure about this. I hope there is a moment where we can detect that the bootstrap phase has finished and that we can migrate the object in cluster. I think there might be 2 approaches:
- Where the k8s API is up, we can started deploying the in-cluster operator and we can mirror every changes and objects that comes up in the external one to have it always in sync. When there is the pivoting when the bootstrap phase has finished, then we start using the in-cluster operator.
- Otherwise, we can do only once when there is the pivoting from the boostraphase from the regular and finished installation.
@patrickdillon if you could help identify when this "pivot" phas happen , it will be great!
They are the end points for the registration and the attestation server (trustee), but you are right, it can be mentioned more explicitly. UPDATE: I added a paragraph with more details about this, PTAL |
Signed-off-by: Alice Frosi <[email protected]>
dff6203 to
2de56be
Compare
|
@alicefr: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.