Skip to content

Comments

feat: Add output and limit to vulnerability-analyze#59

Merged
a-oren merged 1 commit intotrustification:mainfrom
a-oren:update-analyze
Nov 6, 2025
Merged

feat: Add output and limit to vulnerability-analyze#59
a-oren merged 1 commit intotrustification:mainfrom
a-oren:update-analyze

Conversation

@a-oren
Copy link
Collaborator

@a-oren a-oren commented Nov 5, 2025

No description provided.

@a-oren a-oren requested a review from helio-frota November 5, 2025 13:36
@a-oren a-oren force-pushed the update-analyze branch 2 times, most recently from a22b26f to 389a6ee Compare November 5, 2025 14:32
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 26.38889% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.21%. Comparing base (08b966e) to head (0b4f8fa).

Files with missing lines Patch % Lines
nodes/DependencyAnalytics/actions/vulnerability.ts 25.37% 37 Missing and 13 partials ⚠️
nodes/DependencyAnalytics/utils/output.ts 50.00% 1 Missing and 1 partial ⚠️
nodes/DependencyAnalytics/utils/simplify.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #59       +/-   ##
===========================================
- Coverage   83.33%   70.21%   -13.12%     
===========================================
  Files          17       17               
  Lines         252      319       +67     
  Branches       67       97       +30     
===========================================
+ Hits          210      224       +14     
- Misses          5       44       +39     
- Partials       37       51       +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@helio-frota helio-frota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR dropping to < 80% coverage is not a blocker for us.
Good to have, and probably we can work later on that, but not a blocker for this specific repository. 👍

@a-oren a-oren merged commit f0c4b78 into trustification:main Nov 6, 2025
1 check passed
@a-oren a-oren deleted the update-analyze branch November 10, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants