Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Add SBOM Explorer feature description#10

Merged
mrrajan merged 1 commit intotrustification:mainfrom
queria:stories-2.0-sbom
Jan 24, 2025
Merged

Add SBOM Explorer feature description#10
mrrajan merged 1 commit intotrustification:mainfrom
queria:stories-2.0-sbom

Conversation

@queria
Copy link
Collaborator

@queria queria commented Jan 10, 2025

Describe expected tests of behavior for SBOM Explorer page.

@queria queria force-pushed the stories-2.0-sbom branch 2 times, most recently from 71e507e to 15d3f4d Compare January 16, 2025 17:02
@queria queria marked this pull request as ready for review January 16, 2025 17:03
Copy link
Collaborator

@mrrajan mrrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@queria Please find the inline comments and suggestions. I have requested to split scenarios with multiple verification into individuals. Please let me know WDYT.

@queria queria force-pushed the stories-2.0-sbom branch 5 times, most recently from ce53764 to ea49122 Compare January 20, 2025 12:29
Copy link
Collaborator

@mrrajan mrrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a suggestion.

IMHO, we should split the multiple when statements on a scenario into smaller ones and remove the redundant steps or steps with no functional purpose - these changes are better to have and can be carried later as well.

@queria
Copy link
Collaborator Author

queria commented Jan 21, 2025

I have added a suggestion.

IMHO, we should split the multiple when statements on a scenario into smaller ones and remove the redundant steps or steps with no functional purpose - these changes are better to have and can be carried later as well.

// For some reason I am unable to reply inline some of the comments, so will put it in single one here.

Will split most of the scenarios, though i'm quite sure it will result in very inefficient test execution, will have to find some workaround for that in code then. With one exception - filtering packages and clearing the filter input - as there i believe we want to validate both, that list was filtered and that it was reset back.

Yes I agree with the looking at content is likely redundant, as some of the something is visible when next steps does additional assert of its content so there is no need for first step (thanks @carlosthe19916 for pointing it out).

@queria queria marked this pull request as draft January 21, 2025 09:24
@queria queria force-pushed the stories-2.0-sbom branch 6 times, most recently from a613c82 to 09f11c7 Compare January 23, 2025 01:28
Describe expected tests of behavior for SBOM Explorer page.
@queria queria marked this pull request as ready for review January 23, 2025 01:29
@queria queria requested a review from mrrajan January 23, 2025 01:29
Copy link
Collaborator

@mrrajan mrrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrrajan mrrajan merged commit d0676c8 into trustification:main Jan 24, 2025
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants