This repository was archived by the owner on Sep 11, 2025. It is now read-only.
Added test cases for exploring and configuring importers#13
Merged
mrrajan merged 3 commits intotrustification:mainfrom Jan 23, 2025
ikanias:main
Merged
Added test cases for exploring and configuring importers#13mrrajan merged 3 commits intotrustification:mainfrom ikanias:main
mrrajan merged 3 commits intotrustification:mainfrom
ikanias:main
Conversation
mrrajan
suggested changes
Jan 17, 2025
Collaborator
mrrajan
left a comment
mrrajan
left a comment
There was a problem hiding this comment.
@ikanias I have reviewed the Scenario's and it looks fine. But there are some changes needed on the syntax level.
- Leveraging "Background" keyword for before test action with "Given" statement
- Removing "#" before the scenario's.
- Most of the "Then" statement were written in future actions like "will be displayed", "will be greyed out". I request to change it into expected state or behavior with "should be" like "should be displayed", "should greyed out", "should be visible", "should be disable"
I have added couple suggestion for the above changes. Please review and let me know WDYT.
queria
reviewed
Jan 20, 2025
Collaborator
|
Just small details, anyway i think overall it looks good can be merged as is - all such details will have be polished during coding phase anyway. |
queria
approved these changes
Jan 20, 2025
mrrajan
suggested changes
Jan 21, 2025
queria
reviewed
Jan 23, 2025
Collaborator
queria
left a comment
queria
left a comment
There was a problem hiding this comment.
Rajan is right the .swp should not be part of this, so dropping the approval for now.
As this will need updating, please consider also addressing my inline comments (esp duplicit 'the user').
mrrajan
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.