Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Adding License export feature files#8

Merged
mrrajan merged 2 commits intotrustification:mainfrom
mrrajan:add_library_download_features
Jan 20, 2025
Merged

Adding License export feature files#8
mrrajan merged 2 commits intotrustification:mainfrom
mrrajan:add_library_download_features

Conversation

@mrrajan
Copy link
Collaborator

@mrrajan mrrajan commented Jan 10, 2025

Add License export feature files

@mrrajan mrrajan force-pushed the add_library_download_features branch from d1525b8 to a542a39 Compare January 10, 2025 11:27
Signed-off-by: Rajan Ravi <rravi@rravi-thinkpadp1gen4i.bengluru.csb>
@mrrajan mrrajan force-pushed the add_library_download_features branch from a542a39 to e196035 Compare January 10, 2025 11:28
Copy link
Contributor

@vobratil vobratil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a only a handful of minor things. I would split that one step in the User Downloads license information for CycloneDX SBOM from SBOM Search Results page scenario into two steps. The indentation is a minor thing and there were a couple of typos (mixing present and past tense), but I'm not sure if that plays any role in the test code generation at all.

Signed-off-by: Rajan Ravi <rravi@rravi-thinkpadp1gen4i.bengluru.csb>
Copy link
Contributor

@vobratil vobratil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrrajan Thanks, it looks good to me now.

@queria
Copy link
Collaborator

queria commented Jan 20, 2025

/lgtm

@mrrajan mrrajan merged commit b8df49b into trustification:main Jan 20, 2025
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants