Add Importers Mockups#2
Merged
carlosthe19916 merged 6 commits intotrustification:mainfrom Apr 17, 2025
Merged
Conversation
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
Member
Author
|
I did not add logic to the components as these are just mockups and there is no need to too much code. As long as the Stories render an understandably the spirit of the page, it should be enough. |
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
# Conflicts: # src/app/Importers/ImportersPage.tsx
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
kahboom
approved these changes
Apr 17, 2025
Collaborator
kahboom
left a comment
There was a problem hiding this comment.
I love it! Just FYI, after merge I'll be moving these under a section called "v2.1" to separate them from 2.0 stories in another PR shortly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a proposal of how the new Importers Page might look like after the UI Revamp.
Rename
ImportersbyData Sources=> I thinkImportersis an internal terminology that was leaked in the UI. The whole system data will be populated by the Importers and hence I thought it would make sense to rename it as something likeData Sources. Feedback is welcome.