Skip to content

Add Importers Mockups#2

Merged
carlosthe19916 merged 6 commits intotrustification:mainfrom
carlosthe19916:importers
Apr 17, 2025
Merged

Add Importers Mockups#2
carlosthe19916 merged 6 commits intotrustification:mainfrom
carlosthe19916:importers

Conversation

@carlosthe19916
Copy link
Member

This PR adds a proposal of how the new Importers Page might look like after the UI Revamp.

Rename Importers by Data Sources => I think Importers is an internal terminology that was leaked in the UI. The whole system data will be populated by the Importers and hence I thought it would make sense to rename it as something like Data Sources. Feedback is welcome.

  • No Pagination and all importers are rendered in the page.
    • We will never deal with thousands of importers and I think it would be better to render all rows without limiting the user to see only the first 10 ones. Feedback is welcome :)
  • We do not use a Table anymore but a DataList
    • To render more data condensed in a single row I think it would make sense to replace our old Table. Tables force us to render only one type of data per column
  • Each row has an icon at the Left. That icon should indicate the latest outcome of any know execution of the Importers.
  • Replace the Expandable area by a Left Drawer.

Screenshot From 2025-04-16 14-45-28

Screenshot From 2025-04-16 14-45-37

Screenshot From 2025-04-16 14-45-48

Screenshot From 2025-04-16 14-45-50

Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
@carlosthe19916
Copy link
Member Author

I did not add logic to the components as these are just mockups and there is no need to too much code. As long as the Stories render an understandably the spirit of the page, it should be enough.

Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
# Conflicts:
#	src/app/Importers/ImportersPage.tsx
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
@carlosthe19916 carlosthe19916 requested a review from kahboom April 16, 2025 14:40
Copy link
Collaborator

@kahboom kahboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! Just FYI, after merge I'll be moving these under a section called "v2.1" to separate them from 2.0 stories in another PR shortly.

@carlosthe19916 carlosthe19916 merged commit fcb4fe0 into trustification:main Apr 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants